fix: Modified the code for default azure credential#237
Merged
Roopan-Microsoft merged 1 commit intomainfrom Oct 27, 2025
Merged
fix: Modified the code for default azure credential#237Roopan-Microsoft merged 1 commit intomainfrom
Roopan-Microsoft merged 1 commit intomainfrom
Conversation
Roopan-Microsoft
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request refactors how Azure credentials are instantiated throughout the codebase. The main change is to create a single instance of
DefaultAzureCredentialand reuse it when initializing Azure SDK clients, rather than creating a new credential inline for each client. This makes the code more efficient and consistent.Credential initialization refactor:
new DefaultAzureCredential(DefaultAzureCredential.DefaultEnvironmentVariableName)in client constructors are replaced by first creating aDefaultAzureCredentialinstance and then passing it to the client. This affects:AzureStorageQueueService(AzureStorageQueueService.cs)BlobServiceClientinStorageAccessUtil(StorageAccessUtil.cs)DocumentAnalysisClientinAzureAIDocIntelEngine(AzureAIDocIntelEngine.cs)SearchIndexClientinAzureAISearchMemory(AzureAISearchMemory.cs)BlobServiceClientinAzureBlobsStorage(AzureBlobsStorage.cs)AzureOpenAITextEmbeddingGenerationServiceinAzureOpenAITextEmbeddingGenerator(AzureOpenAITextEmbeddingGenerator.cs)OpenAIClientinAzureOpenAITextGenerator(AzureOpenAITextGenerator.cs)QueueClientinAzureQueuesPipeline(AzureQueuesPipeline.cs)This change improves code readability, reduces duplication, and may help with credential caching and performance.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information