refactor: Added comment about setting of env variable in Docker file#238
Merged
Roopan-Microsoft merged 1 commit intomainfrom Oct 30, 2025
Merged
refactor: Added comment about setting of env variable in Docker file#238Roopan-Microsoft merged 1 commit intomainfrom
Roopan-Microsoft merged 1 commit intomainfrom
Conversation
Prajwal-Microsoft
requested review from
Avijit-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Roopan-Microsoft
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request adds inline comments to several places in the codebase where
DefaultAzureCredentialis instantiated using an environment variable. The comments clarify that the environment variable is intentionally set in the Docker file, addressing a CodeQL warning (SM05137). No logic or behavior is changed; these are documentation improvements for static analysis and code reviewers.Key documentation updates:
Credential Initialization Comments:
DefaultAzureCredentialis constructed withDefaultAzureCredential.DefaultEnvironmentVariableName, indicating that the environment variable is set in the Docker file to address CodeQL warning SM05137. This affects the following files and constructors:AzureStorageQueueServiceinAzureStorageQueueService.csGetBlobClientFromConnectionStringinStorageAccessUtil.csAzureAIDocIntelEngineinAzureAIDocIntelEngine.csAzureAISearchMemoryinAzureAISearchMemory.csAzureBlobsStorageinAzureBlobsStorage.csAzureOpenAITextEmbeddingGeneratorinAzureOpenAITextEmbeddingGenerator.csAzureOpenAITextGeneratorinAzureOpenAITextGenerator.csAzureQueuesPipelineinAzureQueuesPipeline.csDoes this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information