fix: Code changes for "CodeQL" issues fix#247
Merged
Roopan-Microsoft merged 7 commits intomainfrom Nov 22, 2025
Merged
Conversation
Services/src/esg-ai-doc-analysis/CFS.SK.Sustainability.AI/ESRSGapAnalysisManager.cs
Fixed
Show fixed
Hide fixed
Services/src/esg-ai-doc-analysis/CFS.SK.Sustainability.AI/Utils/HtmlPdfConverter.cs
Fixed
Show fixed
Hide fixed
…pAnanlysisManager.cs
Services/src/esg-ai-doc-analysis/CFS.SK.Sustainability.AI/ESRSGapAnalysisManager.cs
Fixed
Show fixed
Hide fixed
…spaces or special characters, and addresses CodeQL path injection vulnerability.
Services/src/esg-ai-doc-analysis/CFS.SK.Sustainability.AI/DocumentManager.cs
Outdated
Show resolved
Hide resolved
Services/src/esg-ai-doc-analysis/CFS.SK.Sustainability.AI/ESRSGapAnalysisManager.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
@microsoft-github-policy-service agree company="Microsoft" |
Services/src/esg-ai-doc-analysis/CFS.SK.Sustainability.AI/DocumentManager.cs
Show resolved
Hide resolved
| "processwatcherUrl": "{{ gapanalysisprocesswatcherurl }}" | ||
| }, | ||
| "AntiSSRF": { | ||
| "AllowedDomains": "microsoft.seismic.com" |
Collaborator
There was a problem hiding this comment.
Dont add anu value here. We cannot determine the URL used by users
| "processwatcherUrl": "{{ gapanalysisprocesswatcherurl }}" | ||
| }, | ||
| "AntiSSRF": { | ||
| "AllowedDomains": "microsoft.seismic.com" |
Collaborator
There was a problem hiding this comment.
Dont add anu value here. We cannot determine the URL used by users
Roopan-Microsoft
approved these changes
Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
SSRF and URL Validation Improvements:
AntiSsrfValidationinDocumentManager.csto validate URLs before downloading files, ensuring only HTTPS URLs from allowed domains are accepted and blocking SSRF attacks. [1] [2]File Name and Path Security:
EnsureSafeSimpleFileNameinESRSGapAnalysisManager.csto validate file names for report generation and deletion, preventing path traversal and restricting characters to a safe whitelist. This method is now called before using file names for blob and local file operations. [1] [2] [3] [4]ValidateFilePathinHtmlPdfConverter.csto check file paths for dangerous characters before passing them to external processes, mitigating command injection risks. [1] [2]SQL Injection Prevention:
PostgresSchema.ValidateTableNameinPostgresDbClient.csbefore constructing SQL statements, preventing SQL injection attacks. [1] [2]Documentation and CodeQL Annotations:
These changes collectively strengthen the application's defenses against several security threats by enforcing strict validation of user and system inputs
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information