Skip to content

Conversation

@Abdul-Microsoft
Copy link
Contributor

Purpose

  • This pull request removes several unused infrastructure modules and updates documentation to improve clarity for custom deployments. The main changes are the cleanup of unused Bicep files related to App Service, App Service Plan, App Settings, SQL user/role creation, and AI Search connection, as well as documentation improvements for WAF/private networking deployments and new VM admin parameter descriptions.

Infrastructure cleanup:

  • Removed unused Bicep modules: deploy_app_service.bicep, deploy_app_service_plan.bicep, deploy_appservice-appsettings.bicep, create-sql-user-and-role.bicep, and deploy_aifp_aisearch_connection.bicep to simplify the codebase and eliminate redundant files. [1] [2] [3] [4] [5]

Documentation improvements:

  • Added a detailed note for WAF/private networking deployments in CustomizeData.md, clarifying that data processing scripts must be run from inside the deployed VM and providing step-by-step instructions.
  • Documented new VM admin username and password parameters in CustomizingAzdParameters.md, making it easier for users to configure VM access.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit ca75e7d into dev Sep 19, 2025
6 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the psl-wafstandardization branch September 19, 2025 05:40
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

🎉 This PR is included in version 3.14.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants