fix: down merge to dev from main #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci: fixed pipeline failures
ci: update EXP input handling in deployment workflows
Pavan-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
brittneek,
dgp10801,
nchandhi and
toherman-msft
as code owners
Avijit-Microsoft
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces significant improvements to the deployment workflows for both Linux and Windows environments, focusing on input validation, parameter consistency, and enhanced configurability. The main changes include the addition of a robust input validation job, standardization of input parameter naming, support for a new deployment use case option, and updates to orchestrator logic for better reliability and control.
Workflow Input Validation and Consistency
validate-inputsjob to.github/workflows/deploy-linux.ymlthat rigorously checks all workflow input parameters for correct format, allowed values, and Azure conventions before proceeding with deployment. This prevents misconfiguration and early workflow failures.EXP,AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID,AZURE_EXISTING_AI_PROJECT_RESOURCE_ID) in both Linux and Windows deployment workflows for consistency and to avoid YAML parsing issues. [1] [2] [3] [4]Enhanced Deployment Configuration
AZURE_ENV_USE_CASE(choice betweentelecomandIT_helpdesk) to both Linux and Windows workflows, allowing more flexible deployment scenarios based on the use case. This parameter is validated and propagated throughout the orchestrator and job workflows. [1] [2] [3] [4]Orchestrator Logic and Reliability
.github/workflows/deploy-orchestrator.ymlto use validated outputs from the new input validation job, improving reliability and ensuring only valid configurations are deployed. Also, improved conditional logic for job execution to handle workflow cancellations and success/skipped states more robustly. [1] [2]if: false) in the orchestrator workflow, likely for maintenance or to prevent unintended test executions.These changes collectively make the deployment workflows safer, more flexible, and easier to maintain, reducing the risk of errors due to invalid inputs and supporting future expansion for new use cases.
Does this introduce a breaking change?