updated python and maven versions as well as mocha path #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Brimager <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the development container configuration to improve feature maintenance and use more recent runtimes.
- Switched the
mochafeature source fromdevcontainers-contribtodevcontainers-extra - Added a
mavenVersionpin for the Java feature alongsideinstallMaven - Upgraded the Python feature from 3.8 to 3.11
| }, | ||
| "ghcr.io/devcontainers-contrib/features/mocha:2": { | ||
| "ghcr.io/devcontainers-extra/features/mocha:2": { | ||
| "version": "latest" |
There was a problem hiding this comment.
[nitpick] Consider pinning the Mocha feature version instead of using latest to ensure reproducible container builds.
Suggested change
| "version": "latest" | |
| "version": "2.0.0" |
| }, | ||
| "ghcr.io/devcontainers/features/python:1": { | ||
| "version": "3.8" | ||
| "version": "3.11" |
There was a problem hiding this comment.
[nitpick] To avoid unexpected changes when Python 3.11.x patches are released, consider specifying the full patch version (e.g., 3.11.2).
Suggested change
| "version": "3.11" | |
| "version": "3.11.2" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to development container configuration:
mochafeature fromghcr.io/devcontainers-contribtoghcr.io/devcontainers-extrafor better support and maintenance.javafeature to specifymavenVersionas3.9.10for more precise Maven version control.pythonfeature version from3.8to3.11to use a more recent Python release.This addresses current issues causing the codespace to be broken when loading. Changes will load the codespace now without errors.