feat: Add virtual network location parameter for cognitive services#97
Closed
Vemarthula-Microsoft wants to merge 5 commits intomicrosoft:mainfrom
Closed
feat: Add virtual network location parameter for cognitive services#97Vemarthula-Microsoft wants to merge 5 commits intomicrosoft:mainfrom
Vemarthula-Microsoft wants to merge 5 commits intomicrosoft:mainfrom
Conversation
Vemarthula-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft and
dgp10801
as code owners
| @description('Specifies the location for all the Azure resources. Defaults to the location of the resource group.') | ||
| param location string | ||
| @description('Location of the virtual network (must match VNet region for private endpoints).') | ||
| param virtualNetworkLocation string |
Collaborator
There was a problem hiding this comment.
no need to add this as a parm here, directly pass location to other modules
Collaborator
There was a problem hiding this comment.
This has to be removed and directly use location
…nally in cognitive services module
…tion as a parameter
…esource group location in cognitive services module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…odules
Purpose
This pull request enhances the Azure Cognitive Services infrastructure modules by improving support for network isolation and private endpoints. The main changes introduce a new
virtualNetworkLocationparameter to ensure private endpoints are deployed in the correct region, and update resource references to handle optional outputs more safely.Network Isolation and Private Endpoint Improvements:
virtualNetworkLocationparameter throughout the deployment modules to ensure private endpoints and related resources are created in the same region as the target subnet/VNet. This helps avoid deployment errors and aligns with Azure requirements. [1] [2] [3]aiServices,contentSafety,vision,language,speech,translator,documentIntelligence) to pass the newvirtualNetworkLocationparameter. [1] [2] [3] [4] [5] [6] [7]virtualNetworkLocationinstead of the generallocationparameter, ensuring regional consistency for private endpoints.Optional Output Handling:
.?resourceId,.?foundryConnection), preventing errors if outputs are missing or not set. [1] [2] [3] [4] [5] [6] [7]These changes improve reliability and flexibility when deploying cognitive services with network isolation and private endpoints.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information