Skip to content

Upgrade to CMake 3.21 #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
walbourn merged 2 commits into from
Oct 1, 2025
Merged

Upgrade to CMake 3.21 #248

walbourn merged 2 commits into from
Oct 1, 2025

Conversation

@walbourn
Copy link
Member

@walbourn walbourn commented Sep 16, 2025 •
edited
Loading

  • CMake 3.21 comes with VS 2022.

VS 2019 users will need to install a standalone version of a CMake newer than the 3.20 that comes with it.

  • Minor code review to return E_UNEXPECTED or E_POINTER in places that can't be hit in code paths even with invalid input args--i.e. defense-in-depth checks that make static code analysis happy.

@walbourn walbourn self-assigned this Sep 16, 2025
@walbourn walbourn added the cmake Related to CMake build label Sep 16, 2025
@walbourn
Copy link
Member Author

walbourn commented Sep 16, 2025

Test suite updates walbourn/directxmeshtest@a6674a8

@walbourn walbourn linked an issue Sep 16, 2025 that may be closed by this pull request
Update CMake to require version 3.21 #188
Closed
@walbourn walbourn merged commit 602dde8 into main Oct 1, 2025
107 checks passed
@walbourn walbourn deleted the cmake321 branch October 1, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nadaOuf nadaOuf nadaOuf approved these changes

Assignees

@walbourn walbourn

Labels

cmake Related to CMake build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update CMake to require version 3.21

3 participants

@walbourn @nadaOuf