[SPIR-V] Fix Mesh Shader debug info source locations #8057
+41
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
SteveUrquhart
force-pushed
the
fix-mesh-shader-locations
branch
from
dd8a57e to
0b6a9ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dxc outputs incorrect line information for some mesh shader inputs, as shown in this godbolt. The final 6 OpStore instructions should be on lines 12-19 where the assignment occurs, but instead they are associated with lines 2 and 3 where the struct fields are declared. This is broken for all forms of debug info, not just NS.