[SM6.10] Complete ClusterID implementation #8065
Open
+627
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add logic to check AvailabilityAttribute on member functions (wasn't checked before). Required for RQ / HitObject cluster methods. - Lowering for all ClusterID variants with tests - CLUSTER_ID_INVALID definition and tests - Validation logic with expected pass and fail tests
tex3d
approved these changes
Jan 16, 2026
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
Looks good, just one needed test requirement.
tools/clang/test/CodeGenDXIL/hlsl/intrinsics/clusterid_invalid_constant.hlsl
Show resolved
Hide resolved
…_constant.hlsl Co-authored-by: Tex Riddell <[email protected]>
tex3d
approved these changes
Jan 16, 2026
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8041