Skip to content

Comments

Script for batch migration legacy to msi#1517

Merged
wanlonghenry merged 18 commits intoci_prodfrom
longw/legacy-migration-scripts
Sep 2, 2025
Merged

Script for batch migration legacy to msi#1517
wanlonghenry merged 18 commits intoci_prodfrom
longw/legacy-migration-scripts

Conversation

@wanlonghenry
Copy link
Contributor

@wanlonghenry wanlonghenry commented Aug 19, 2025 •
edited
Loading

Script for batch migration legacy to msi
image
image
image
image
image
image

@wanlonghenry wanlonghenry requested a review from a team as a code owner August 19, 2025 23:22
ganga1980
ganga1980 reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@ganga1980 ganga1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments

@zanejohnson-azure
Copy link
Contributor

zanejohnson-azure commented Aug 20, 2025

i think we miss the scenarios for cluster using private link, the az command to enable ci will be different from what in the current script.

I think we first need list the scenarios we want to cover first, then workbacks to develop the script.

besides typical path, we need perform tests in different setup.

  1. will the script work in configMap scenario?
  2. geneva path
  3. any others?

@wanlonghenry wanlonghenry merged commit 391fd42 into ci_prod Sep 2, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanejohnson-azure zanejohnson-azure zanejohnson-azure left review comments

@ganga1980 ganga1980 ganga1980 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wanlonghenry @zanejohnson-azure @ganga1980