Skip to content

Starting points and retraining #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
godcallray wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Starting points and retraining #831

godcallray wants to merge 17 commits into from

Conversation

@godcallray
Copy link

@godcallray godcallray commented Nov 29, 2022 •
edited
Loading

Why are these changes needed?

It is because that the corresponding correct error and warning information are very useful.

Related issue number

#804
#800

Checks

@qingyun-wu qingyun-wu self-assigned this Nov 29, 2022
@godcallray
Copy link
Author

godcallray commented Nov 30, 2022 •
edited
Loading

I added the corresponding warning and error information as required
#804
#800

@godcallray godcallray changed the title Zhaobranch Starting points and retraining Dec 1, 2022
@godcallray
Copy link
Author

godcallray commented Dec 27, 2022

@microsoft-github-policy-service agree company="Pennsylvania State University"

sonichi
sonichi reviewed Dec 27, 2022
View reviewed changes
Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#800 has an unaddressed issue. Please check the whole conversation.

flaml/automl/automl.py Outdated
self._trained_estimator.params[self._trained_estimator.ITER_HP]
!= self.best_config[self._trained_estimator.ITER_HP]
):
logger.warning("early stopping happened")
Copy link
Contributor

@sonichi sonichi Dec 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the code coverage. If not covered, add a test case. Also, change the warning message as it is ambiguous.

sonichi
sonichi reviewed Dec 30, 2022
View reviewed changes
sonichi
sonichi reviewed Jan 1, 2023
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skzhang1 skzhang1 Awaiting requested review from skzhang1

@qingyun-wu qingyun-wu Awaiting requested review from qingyun-wu

1 more reviewer

@sonichi sonichi sonichi left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@qingyun-wu qingyun-wu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godcallray @sonichi @qingyun-wu