Skip to content

Update FilterCollectionExtensions #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update FilterCollectionExtensions #359

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1fdf4f5
update
zhiyuanliang-ms Feb 1, 2024
1f9ff9d
update
zhiyuanliang-ms Feb 1, 2024
bf5ee68
update
zhiyuanliang-ms Feb 1, 2024
3a905a0
Merge branch 'main' into zhiyuanliang/update-filter-collection-extens…
zhiyuanliang-ms May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/Microsoft.FeatureManagement.AspNetCore/FilterCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,12 @@ public static class FilterCollectionExtensions
/// <typeparam name="TFilterType">The MVC filter to add and use if the feature is enabled.</typeparam>
/// <param name="filters">The filter collection to add to.</param>
/// <param name="feature">The feature that will need to enabled to trigger the execution of the MVC filter.</param>
/// <returns></returns>
public static IFilterMetadata AddForFeature<TFilterType>(this FilterCollection filters, string feature) where TFilterType : IAsyncActionFilter
/// <returns>The reference to the filter collection.</returns>
public static FilterCollection AddForFeature<TFilterType>(this FilterCollection filters, string feature) where TFilterType : IAsyncActionFilter
{
IFilterMetadata filterMetadata = null;

filters.Add(new FeatureGatedAsyncActionFilter<TFilterType>(feature));

return filterMetadata;
return filters;
}
}
}