perf(client-container-runtime): reduce semver bundle regression#24486
Merged
jason-ha merged 1 commit intorelease/client/2.33from May 1, 2025
Merged
perf(client-container-runtime): reduce semver bundle regression#24486jason-ha merged 1 commit intorelease/client/2.33from
semver bundle regression#24486jason-ha merged 1 commit intorelease/client/2.33from
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve performance by replacing the legacy semver operations with tree-shakable ESM imports from semver-ts.
- Replace internal semver imports with semver-ts equivalents.
- Update version sorting and compatibility checks to use the new semver-ts functions.
Files not reviewed (2)
- packages/runtime/container-runtime/package.json: Language not supported
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
packages/runtime/container-runtime/src/compatUtils.ts:178
- Please verify that semver-ts's 'compare' function orders semantic version strings in the desired ascending order, ensuring that the logic remains consistent with the previous implementation.
const versions = Object.keys(config).sort(compare);
Contributor
|
Warning WARNING: This PR is targeting a release branch! All changes must first be merged into Changes to release branches require approval from the Patch Triage group before merging. For more details, see our internal documentation for the patch policy and processes for |
scottn12
approved these changes
Apr 30, 2025
using ESM and tree-shakable `semver-ts`
4e26e38 to
c040f2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using ESM and tree-shakable
semver-ts.PR to main: #24483