Skip to content

perf(client-container-runtime): reduce semver bundle regression#24486

Merged
jason-ha merged 1 commit intorelease/client/2.33from
test/client/2.33/semver-perf-fix
May 1, 2025
Merged

perf(client-container-runtime): reduce semver bundle regression#24486
jason-ha merged 1 commit intorelease/client/2.33from
test/client/2.33/semver-perf-fix

Conversation

@jason-ha
Copy link
Contributor

@jason-ha jason-ha commented Apr 30, 2025

using ESM and tree-shakable semver-ts.

PR to main: #24483

@jason-ha jason-ha requested review from Copilot and scottn12 April 30, 2025 16:17
@github-actions github-actions bot added the base: release PRs targeted against a release branch label Apr 30, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to improve performance by replacing the legacy semver operations with tree-shakable ESM imports from semver-ts.

  • Replace internal semver imports with semver-ts equivalents.
  • Update version sorting and compatibility checks to use the new semver-ts functions.
Files not reviewed (2)
  • packages/runtime/container-runtime/package.json: Language not supported
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

packages/runtime/container-runtime/src/compatUtils.ts:178

  • Please verify that semver-ts's 'compare' function orders semantic version strings in the desired ascending order, ensuring that the logic remains consistent with the previous implementation.
const versions = Object.keys(config).sort(compare);

@github-actions github-actions bot added area: runtime Runtime related issues dependencies Pull requests that update a dependency file labels Apr 30, 2025
@github-actions
Copy link
Contributor

Warning

WARNING: This PR is targeting a release branch!

All changes must first be merged into main and then backported to the target release branch.
Please include a link to the main PR in the description of this PR.

Changes to release branches require approval from the Patch Triage group before merging.
You should have already discussed this change with them so they know to expect it.

For more details, see our internal documentation for the patch policy and processes for
patch releases.

Copy link

@frankmueller-msft frankmueller-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get 🚢 ing.

@jason-ha jason-ha enabled auto-merge (squash) April 30, 2025 20:45
@jason-ha jason-ha disabled auto-merge April 30, 2025 22:49
@jason-ha jason-ha force-pushed the test/client/2.33/semver-perf-fix branch from 4e26e38 to c040f2a Compare May 1, 2025 17:58
@jason-ha jason-ha enabled auto-merge (squash) May 1, 2025 18:04
Copy link

@frankmueller-msft frankmueller-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still approve

@jason-ha jason-ha merged commit 510e071 into release/client/2.33 May 1, 2025
36 checks passed
@jason-ha jason-ha deleted the test/client/2.33/semver-perf-fix branch May 1, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: runtime Runtime related issues base: release PRs targeted against a release branch dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants