Skip to content

improvement(container-runtime): For resubmit, don't submit ID Allocation op until submitting another op #24545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markfields wants to merge 12 commits into from

Move clearing of outstandingUnfinalizedIdCreationRangeOp

73c3cf9
Select commit
Loading
Failed to load commit list.
Closed

improvement(container-runtime): For resubmit, don't submit ID Allocation op until submitting another op #24545

Move clearing of outstandingUnfinalizedIdCreationRangeOp
73c3cf9
Select commit
Loading
Failed to load commit list.
Azure Pipelines / Build - client packages failed Jun 6, 2025 in 38m 36s

Build #341293 had test failures

5 errors / 18 warnings

Details

Tests

  • Failed: 101 (0.35%)
  • Passed: 27,940 (96.40%)
  • Other: 943 (3.25%)
  • Total: 28,984
Code coverage

  • 245576 of 302429 line covered (81.20%)

Annotations

Check failure on line 81 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Build - client packages

Build log #L81 

Error: Npm failed with return code: 1

Check failure on line 8807 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Build - client packages

Build log #L8807 

Error: Npm failed with return code: 1

Check failure on line 34202 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Build - client packages

Build log #L34202 

Error: Npm failed with return code: 1

Check failure on line 2238 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Build - client packages

Build log #L2238 

Error: Npm failed with return code: 1

Check failure on line 1 in can be connected to another tree

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Build - client packages

can be connected to another tree 

Test failed
Raw output 
Invalid use of SharedTree after it was put into an invalid state by another error.
Original Error:
Error: No IDs have ever been finalized by the supplied session.
Error: Invalid use of SharedTree after it was put into an invalid state by another error.
Original Error:
Error: No IDs have ever been finalized by the supplied session.
    at Breakable.use (file:///mnt/vss/_work/1/s/packages/dds/tree/src/util/breakable.ts:34:10)
    at _classThis.replacementMethod (file:///mnt/vss/_work/1/s/packages/dds/tree/src/util/breakable.ts:158:16)
    at Object.contentSnapshot (file:///mnt/vss/_work/1/s/packages/dds/tree/src/shared-tree/sharedTree.ts:372:32)
    at validateTreeConsistency (file:///mnt/vss/_work/1/s/packages/dds/tree/src/test/utils.ts:669:9)
    at Context.<anonymous> (file:///mnt/vss/_work/1/s/packages/dds/tree/src/test/shared-tree/sharedTree.spec.ts:412:3)

Check failure on line 1 in can summarize and load

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Build - client packages

can summarize and load 

Test failed
Raw output 
No IDs have ever been finalized by the supplied session.
Error: No IDs have ever been finalized by the supplied session.
    at IdCompressor.normalizeToSessionSpace (file:///mnt/vss/_work/1/s/packages/runtime/id-compressor/src/idCompressor.ts:456:12)
    at RevisionTagCodec.decode (file:///mnt/vss/_work/1/s/packages/dds/tree/src/core/rebase/revisionTagCodec.ts:38:28)
    at Object.decode (file:///mnt/vss/_work/1/s/packages/dds/tree/src/shared-tree-core/messageCodecs.ts:136:39)
    at Object.decode (file:///mnt/vss/_work/1/s/packages/dds/tree/src/codec/codec.ts:348:17)
    at Object.decode (file:///mnt/vss/_work/1/s/packages/dds/tree/src/codec/versioned/codec.ts:100:22)
    at Object.decode (file:///mnt/vss/_work/1/s/packages/dds/tree/src/codec/versioned/codec.ts:51:26)
    at _classThis.processMessagesCore (file:///mnt/vss/_work/1/s/packages/dds/tree/src/shared-tree-core/sharedTreeCore.ts:344:52)
    at file:///mnt/vss/_work/1/s/packages/dds/tree/src/util/breakable.ts:136:18
    at Breakable.run (file:///mnt/vss/_work/1/s/packages/dds/tree/src/util/breakable.ts:79:11)
    at _classThis.replacementMethod (file:///mnt/vss/_work/1/s/packages/dds/tree/src/util/breakable.ts:135:23)
    at SharedObjectFromKernel.processMessagesCore (file:///mnt/vss/_work/1/s/packages/dds/shared-object-base/src/sharedObjectKernel.ts:193:16)
    at file:///mnt/vss/_work/1/s/packages/dds/shared-object-base/src/sharedObject.ts:1103:4
    at SampledTelemetryHelper.measure (file:///mnt/vss/_work/1/s/packages/utils/telemetry-utils/src/sampledTelemetryHelper.ts:196:23)
    at processMessagesCoreHelper (file:///mnt/vss/_work/1/s/packages/dds/shared-object-base/src/sharedObject.ts:1101:21)
    at SharedObjectFromKernel.SharedObjectCore.processMessagesHelper (file:///mnt/vss/_work/1/s/packages/dds/shared-object-base/src/sharedObject.ts:189:7)
    at SharedObjectFromKernel.processMessages (file:///mnt/vss/_work/1/s/packages/dds/shared-object-base/src/sharedObject.ts:700:8)
    at Object.processMessages (file:///mnt/vss/_work/1/s/packages/dds/shared-object-base/src/sharedObject.ts:585:10)
    at ChannelDeltaConnection.processMessages (file:///mnt/vss/_work/1/s/packages/runtime/datastore/src/channelDeltaConnection.ts:107:17)
    at LazyPromise.execute (file:///mnt/vss/_work/1/s/packages/runtime/datastore/src/remoteChannelContext.ts:115:35)
    at TestFluidObjectInternal.getInitialSharedObjectTyped (file:///mnt/vss/_work/1/s/packages/test/test-utils/src/testFluidObjectInternal.ts:84:19)
    at Function.getTree (file:///mnt/vss/_work/1/s/packages/dds/tree/src/test/utils.ts:322:16)
    at Proxy.createTree (file:///mnt/vss/_work/1/s/packages/dds/tree/src/test/utils.ts:351:16)
    at Context.<anonymous> (file:///mnt/vss/_work/1/s/packages/dds/tree/src/test/shared-tree/sharedTree.spec.ts:432:23)

Check failure on line 1 in can process ops after loading from summary

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Build - client packages

can process ops after loading from summary 

Test failed
Raw output 
Invalid use of SharedTree after it was put into an invalid state by another error.
Original Error:
Error: No IDs have ever been finalized by the supplied session.
Error: Invalid use of SharedTree after it was put into an invalid state by another error.
Original Error:
Error: No IDs have ever been finalized by the supplied session.
    at Breakable.use (file:///mnt/vss/_work/1/s/packages/dds/tree/src/util/breakable.ts:34:10)
    at Breakable.run (file:///mnt/vss/_work/1/s/packages/dds/tree/src/util/breakable.ts:77:8)
    at _classThis.replacementMethod (file:///mnt/vss/_work/1/s/packages/dds/tree/src/util/breakable.ts:135:23)
    at Context.<anonymous> (file:///mnt/vss/_work/1/s/packages/dds/tree/src/test/shared-tree/sharedTree.spec.ts:651:23)

Check failure on line 1 in can load from summary

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Build - client packages

can load from summary 

Test failed
Raw output 
No IDs have ever been finalized by the supplied session.
Error: No IDs have ever been finalized by the supplied session.
    at IdCompressor.normalizeToSessionSpace (file:///mnt/vss/_work/1/s/packages/runtime/id-compressor/src/idCompressor.ts:456:12)
    at RevisionTagCodec.decode (file:///mnt/vss/_work/1/s/packages/dds/tree/src/core/rebase/revisionTagCodec.ts:38:28)
    at Object.decode (file:///mnt/vss/_work/1/s/packages/dds/tree/src/shared-tree-core/messageCodecs.ts:136:39)
    at Object.decode (file:///mnt/vss/_work/1/s/packages/dds/tree/src/codec/codec.ts:348:17)
    at Object.decode (file:///mnt/vss/_work/1/s/packages/dds/tree/src/codec/versioned/codec.ts:100:22)
    at Object.decode (file:///mnt/vss/_work/1/s/packages/dds/tree/src/codec/versioned/codec.ts:51:26)
    at _classThis.processMessagesCore (file:///mnt/vss/_work/1/s/packages/dds/tree/src/shared-tree-core/sharedTreeCore.ts:344:52)
    at file:///mnt/vss/_work/1/s/packages/dds/tree/src/util/breakable.ts:136:18
    at Breakable.run (file:///mnt/vss/_work/1/s/packages/dds/tree/src/util/breakable.ts:79:11)
    at _classThis.replacementMethod (file:///mnt/vss/_work/1/s/packages/dds/tree/src/util/breakable.ts:135:23)
    at SharedObjectFromKernel.processMessagesCore (file:///mnt/vss/_work/1/s/packages/dds/shared-object-base/src/sharedObjectKernel.ts:193:16)
    at file:///mnt/vss/_work/1/s/packages/dds/shared-object-base/src/sharedObject.ts:1103:4
    at SampledTelemetryHelper.measure (file:///mnt/vss/_work/1/s/packages/utils/telemetry-utils/src/sampledTelemetryHelper.ts:196:23)
    at processMessagesCoreHelper (file:///mnt/vss/_work/1/s/packages/dds/shared-object-base/src/sharedObject.ts:1101:21)
    at SharedObjectFromKernel.SharedObjectCore.processMessagesHelper (file:///mnt/vss/_work/1/s/packages/dds/shared-object-base/src/sharedObject.ts:189:7)
    at SharedObjectFromKernel.processMessages (file:///mnt/vss/_work/1/s/packages/dds/shared-object-base/src/sharedObject.ts:700:8)
    at Object.processMessages (file:///mnt/vss/_work/1/s/packages/dds/shared-object-base/src/sharedObject.ts:585:10)
    at ChannelDeltaConnection.processMessages (file:///mnt/vss/_work/1/s/packages/runtime/datastore/src/channelDeltaConnection.ts:107:17)
    at LazyPromise.execute (file:///mnt/vss/_work/1/s/packages/runtime/datastore/src/remoteChannelContext.ts:115:35)
    at RemoteChannelContext.getGCDataInternal (file:///mnt/vss/_work/1/s/packages/runtime/datastore/src/remoteChannelContext.ts:262:19)
    at SummarizerNodeWithGC.getGCData (file:///mnt/vss/_work/1/s/packages/runtime/container-runtime/src/summary/summarizerNode/summarizerNodeWithGc.ts:195:18)
    at file:///mnt/vss/_work/1/s/packages/runtime/datastore/src/dataStoreRuntime.ts:1024:27
    at RuntimeWithRequestHandler.visitContextsDuringSummary (file:///mnt/vss/_work/1/s/packages/runtime/datastore/src/dataStoreRuntime.ts:1122:4)
    at RuntimeWithRequestHandler.getGCData (file:///mnt/vss/_work/1/s/packages/runtime/datastore/src/dataStoreRuntime.ts:1022:3)
    at SummarizerNodeWithGC.getGCData (file:///mnt/vss/_work/1/s/packages/runtime/container-runtime/src/summary/summarizerNode/summarizerNodeWithGc.ts:195:18)
    at visitContextsDuringSummary.fullGC.fullGC (file:///mnt/vss/_work/1/s/packages/runtime/container-runtime/src/channelCollection.ts:1363:27)
    at ChannelCollection.visitContextsDuringSummary (file:///mnt/vss/_work/1/s/packages/runtime/container-runtime/src/channelCollection.ts:1315:5)
    at ChannelCollection.getGCData (file:///mnt/vss/_work/1/s/packages/runtime/container-runtime/src/channelCollection.ts:1361:3)
    at SummarizerNodeWithGC.getGCData (file:///mnt/vss/_work/1/s/packages/runtime/container-runtime/src/summary/summarizerNode/summarizerNodeWithGc.ts:195:18)
    at ContainerRuntime.getGCData (file:///mnt/vss/_work/1/s/packages/runtime/container-runtime/src/containerRuntime.ts:3811:20)
    at GarbageCollector.runGC (file:///mnt/vss/_work/1/s/packages/runtime/container-runtime/src/gc/garbageCollection.ts:614:1
View more details on Azure Pipelines