build(server): Update Typetests (#25016)#25018
build(server): Update Typetests (#25016)#25018scottn12 merged 1 commit intomicrosoft:release/server/7.0from
Conversation
This PR updates the typetests for server packages to the latest release (7.0.0)
|
Warning WARNING: This PR is targeting a release branch! All changes must first be merged into Changes to release branches require approval from the Patch Triage group before merging. For more details, see our internal documentation for the patch policy and processes for |
There was a problem hiding this comment.
Pull Request Overview
Update generated type-compatibility tests and bump previous-server package versions to 7.0.0 across routerlicious sub-packages.
- Bump all
@fluidframework/*-previousdependencies from5.0.0to7.0.0. - Clear out existing
typeValidation.brokenentries in eachpackage.json. - Regenerate and extend
validate*Previous.generated.tsto remove outdated@ts-expect-errorlines and add new forward/backward compatibility checks.
Reviewed Changes
Copilot reviewed 34 out of 35 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| server/routerlicious/packages/test-utils/src/test/types/validateServerTestUtilsPrevious.generated.ts | Regenerate compatibility tests for TestCheck, TestClusterDrainingStatusChecker, TestFluidAccessTokenGenerator, TestReadinessCheck |
| server/routerlicious/packages/test-utils/package.json | Bump server-test-utils-previous to 7.0.0 and reset broken config |
| server/routerlicious/packages/services/src/test/types/validateServerServicesPrevious.generated.ts | Add new compatibility tests for CollaborationSessionTracker and RedisCollaborationSessionManager |
| server/routerlicious/packages/services/package.json | Bump server-services-previous to 7.0.0 and clear broken config |
| server/routerlicious/packages/services-utils/src/test/types/validateServerServicesUtilsPrevious.generated.ts | Add tests for AsyncLocalStorageAbortControllerContext, DenyList, ResponseSizeMiddleware |
| server/routerlicious/packages/services-utils/package.json | Bump server-services-utils-previous to 7.0.0 and clear broken config |
| server/routerlicious/packages/services-telemetry/src/test/types/validateServerServicesTelemetryPrevious.generated.ts | Remove outdated @ts-expect-error and add isTelemetryContextProperties test |
| server/routerlicious/packages/services-telemetry/package.json | Bump server-services-telemetry-previous to 7.0.0 and clear broken config |
| server/routerlicious/packages/services-shared/src/test/types/validateServerServicesSharedPrevious.generated.ts | Add compatibility tests for StartupCheck, closeRedisClientConnections, createHealthCheckEndpoints |
| server/routerlicious/packages/services-shared/package.json | Bump server-services-shared-previous to 7.0.0 |
| server/routerlicious/packages/services-ordering-zookeeper/package.json | Bump server-services-ordering-zookeeper-previous to 7.0.0 |
| server/routerlicious/packages/services-ordering-rdkafka/src/test/types/validateServerServicesOrderingRdkafkaPrevious.generated.ts | Remove outdated @ts-expect-error for RdkafkaConsumer |
| server/routerlicious/packages/services-ordering-rdkafka/package.json | Bump server-services-ordering-rdkafka-previous to 7.0.0 and clear broken config |
| server/routerlicious/packages/services-ordering-kafkanode/src/test/types/validateServerServicesOrderingKafkanodePrevious.generated.ts | Remove outdated @ts-expect-error for KafkaNodeProducer |
| server/routerlicious/packages/services-ordering-kafkanode/package.json | Bump server-services-ordering-kafkanode-previous to 7.0.0 |
| server/routerlicious/packages/services-core/src/test/types/validateServerServicesCorePrevious.generated.ts | Remove outdated @ts-expect-error and add isCompleteBoxcarMessage test |
| server/routerlicious/packages/services-core/package.json | Bump server-services-core-previous to 7.0.0 and clear broken config |
| server/routerlicious/packages/services-client/src/test/types/validateServerServicesClientPrevious.generated.ts | Remove outdated @ts-expect-error and add compatibility tests for parseToken, setupAxiosInterceptorsForAbortSignals |
| server/routerlicious/packages/services-client/package.json | Bump server-services-client-previous to 7.0.0 and reset broken config |
| server/routerlicious/packages/routerlicious/package.json | Remove server-routerlicious-previous, disable validation, and clear broken config |
| server/routerlicious/packages/routerlicious-base/src/test/types/validateServerRouterliciousBasePrevious.generated.ts | Remove multiple outdated @ts-expect-error lines |
| server/routerlicious/packages/routerlicious-base/package.json | Bump server-routerlicious-base-previous to 7.0.0 and clear broken config |
| server/routerlicious/packages/protocol-base/package.json | Bump protocol-base-previous to 7.0.0 |
| server/routerlicious/packages/memory-orderer/src/test/types/validateServerMemoryOrdererPrevious.generated.ts | Remove outdated @ts-expect-error tests |
| server/routerlicious/packages/memory-orderer/package.json | Bump server-memory-orderer-previous to 7.0.0 and clear broken config |
| server/routerlicious/packages/local-server/src/test/types/validateServerLocalServerPrevious.generated.ts | Remove outdated @ts-expect-error for LocalOrdererManager |
| server/routerlicious/packages/local-server/package.json | Bump server-local-server-previous to 7.0.0 and clear broken config |
| server/routerlicious/packages/lambdas/src/test/types/validateServerLambdasPrevious.generated.ts | Add tests for LambdaCircuitBreaker and remove old @ts-expect-error for ScriptoriumLambda |
| server/routerlicious/packages/lambdas/package.json | Bump server-lambdas-previous to 7.0.0 and clear broken config |
| server/routerlicious/packages/lambdas-driver/src/test/types/validateServerLambdasDriverPrevious.generated.ts | Fix generic signatures for DocumentLambdaFactory and remove outdated @ts-expect-error |
| server/routerlicious/packages/lambdas-driver/package.json | Bump server-lambdas-driver-previous to 7.0.0 and clear broken config |
| server/routerlicious/packages/kafka-orderer/src/test/types/validateServerKafkaOrdererPrevious.generated.ts | Remove outdated @ts-expect-error for KafkaOrdererConnection |
| server/routerlicious/packages/kafka-orderer/package.json | Bump server-kafka-orderer-previous to 7.0.0 and clear broken config |
| server/routerlicious/packages/gitresources/package.json | Bump gitresources-previous to 7.0.0 |
Files not reviewed (1)
- server/routerlicious/pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
server/routerlicious/packages/services-client/src/test/types/validateServerServicesClientPrevious.generated.ts:304
- The function name
convertAxiosErrorToNetorkErrorappears to have a typo ('Netork' instead of 'Network'). Please correct the spelling in the implementation and update all references.
declare type current_as_old_for_Function_convertAxiosErrorToNetorkError = requireAssignableTo<TypeOnly<typeof current.convertAxiosErrorToNetorkError>, TypeOnly<typeof old.convertAxiosErrorToNetorkError>>
90e0404
into
microsoft:release/server/7.0
This PR cherry-picks #25016 to update the typetests to the latest server packages (7.0.0)