Skip to content

Add disposal method to SerializedStateManager for snapshot refresh timer cleanup #25200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RishhiB wants to merge 1 commit into from
Closed

Add disposal method to SerializedStateManager for snapshot refresh timer cleanup #25200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/loader/container-loader/src/container.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1158,6 +1158,9 @@ export class Container

this.storageAdapter.dispose();

// Dispose serialized state manager to clean up snapshot refresh timer
this.serializedStateManager.dispose();

// Notify storage about critical errors. They may be due to disconnect between client & server knowledge
// about file, like file being overwritten in storage, but client having stale local cache.
// Driver need to ensure all caches are cleared on critical errors
Expand Down
8 changes: 8 additions & 0 deletions packages/loader/container-loader/src/serializedStateManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,14 @@ export class SerializedStateManager {
},
);
}

/**
* Dispose of the SerializedStateManager, cleaning up any active timers.
* This prevents Node.js processes from hanging due to the refresh timer.
*/
public dispose(): void {
this.refreshTimer.clear();
Copy link

Copilot AI Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dispose method should check if refreshTimer exists before calling clear() to avoid potential runtime errors if dispose() is called multiple times or if the timer was never initialized.

Suggested change
this.refreshTimer.clear();
if (this.refreshTimer) {
this.refreshTimer.clear();
}

Copilot uses AI. Check for mistakes.
}
}

/**
Expand Down
Loading