refactor(tree): Support pausing Tree events for table operations #25298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring-transactions
github-actions
bot
added
base: main
Josmithr
commented
Aug 25, 2025
| @@ -768,33 +786,10 @@ export class AnchorSet implements AnchorLocator { | |||
| } | |||
| this.anchorSet.activeVisitor = undefined; | |||
|
|
|||
| // Aggregate changedFields by node. | |||
| const eventsByNode: Map<PathNode, Set<FieldKey>> = new Map(); | |||
There was a problem hiding this comment.
Note for reviewers: extracted into a static function below so it can be reused. This functionality doesn't consume any object state, so no functional changes were required.
Josmithr
commented
Aug 25, 2025
| @@ -219,9 +219,7 @@ export class TreeNodeKernel { | |||
| for (const eventName of kernelEvents) { | |||
| if (events.hasListeners(eventName)) { | |||
| this.#hydrationState.offAnchorNode.add( | |||
| // Argument is forwarded between matching events, so the type should be correct. | |||
There was a problem hiding this comment.
Note for reviewers: this explicit typing as any was not needed, so it was removed.
…ring-transactions
Josmithr
commented
Aug 28, 2025
| @@ -768,6 +768,7 @@ export interface RunTransaction { | |||
|
|
|||
| // @alpha @input | |||
| export interface RunTransactionParams { | |||
| readonly deferTreeEvents?: boolean; | |||
Josmithr
changed the title
Josmithr
commented
Aug 28, 2025
| @@ -66,6 +66,7 @@ import { | |||
|
|
|||
| import { canInitialize, initialize, initializerFromChunk } from "./schematizeTree.js"; | |||
| import type { ITreeCheckout, TreeCheckout } from "./treeCheckout.js"; | |||
| import { pauseTreeEvents } from "../simple-tree/index.js"; | |||
There was a problem hiding this comment.
TODO: revert all these changes
Josmithr
commented
Aug 28, 2025
| return []; | ||
| } | ||
|
|
||
| // Ensure the specified columns exists before starting transaction. | ||
| // Ensure the specified rows exists before starting transaction. |
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO