Skip to content

test(directory): Update new SharedDirectory.forEach() test #25303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2025
+7 −4
Merged

test(directory): Update new SharedDirectory.forEach() test #25303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a72c10
update .forEach test
scottn12 Aug 25, 2025
77970e6
Merge branch 'main' into updateForEachTest
scottn12 Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/dds/map/src/test/mocha/directory.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1064,18 +1064,21 @@ describe("Directory", () => {
// eslint-disable-next-line unicorn/no-array-for-each
directory1.forEach((value, key) => {
assert(i < values.length, "forEach() should not have iterated more than i times");
assert.strictEqual(key, values[i][0], "key should match");
assert.strictEqual(value, values[i][1], "value should match");
assert.equal(key, values[i][0], "key should match");
assert.equal(value, values[i][1], "value should match");
i++;
});
assert.equal(i, values.length, "forEach() should have iterated i times");

i = 0;
// eslint-disable-next-line unicorn/no-array-for-each
directory2.forEach((value, key) => {
assert(i < values.length, "forEach() should not have iterated more than i times");
assert.strictEqual(key, values[i][0], "key should match");
assert.strictEqual(value, values[i][1], "value should match");
assert.equal(key, values[i][0], "key should match");
assert.equal(value, values[i][1], "value should match");
i++;
});
assert.equal(i, values.length, "forEach() should have iterated i times");
});

it("Shouldn't clear value if there is pending set", () => {
Expand Down
Loading