Export StagingMode as legacy/alpha

[anthony-murphy]

Adds a legacy/alpha entrypoint to runtime-definitions, and exports staging mode as legacy/alpha.

[Copilot]

Pull Request Overview

This PR adds a legacy/alpha entrypoint to runtime-definitions and exports staging mode as legacy/alpha instead of legacy/beta. It also fixes an issue in the build tools where node10 compatibility files weren't properly handling relative paths in nested subdirectories.

Key changes:

• Moves staging mode APIs from legacy/beta to legacy/alpha classification
• Adds a new legacy/alpha entrypoint to runtime-definitions package
• Fixes build tool path resolution for nested subdirectory entrypoints

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
patches/@fluid-tools__build-cli@0.58.1.patch	Adds patch for build CLI to fix relative path handling in nested directories
packages/runtime/runtime-definitions/src/dataStoreContext.ts	Changes staging mode APIs from @legacy @beta to @legacy @Alpha
packages/runtime/runtime-definitions/package.json	Adds legacy/alpha entrypoint and splits build scripts for both legacy levels
packages/runtime/runtime-definitions/api-report/runtime-definitions.legacy.beta.api.md	Removes staging mode APIs from legacy beta API report
packages/runtime/datastore/src/dataStoreRuntime.ts	Removes eslint-disable comments for deprecated imports
packages/runtime/container-runtime/src/containerRuntime.ts	Removes eslint-disable comments for deprecated imports
package.json	Adds the new build CLI patch to patchedDependencies
build-tools/packages/build-cli/src/library/commands/generateEntrypoints.ts	Fixes path resolution for nested directory entrypoints using relative paths

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

[jason-ha]

Patches are not great for toolchain validation. We can release build tools updates pretty easily; so I recommend using normal flow.

[anthony-murphy]

this just included legacy alpha, which is not needed now, as the public and beta rule above will appropriately cover legacy for public and beta, and legacy alpha no longer needs api review

[Josmithr]

Yay! Less special-ness!

[jason-ha]

Seems like there is a strong relationship with StageControlsAlpha. When this goes internal, should it extend StageControlsAlpha?
Otherwise, probably should comment the overlap.

Same comment for similar other cases.

[anthony-murphy]

yeah. i plan to inherit after we release, and partners move to alpha. i don't want to disrupt active prototyping

[jason-ha]

This looks worse. No better options?
We should probably comment most as use outside of type guards. We should definitely comment cast through unknown.

[anthony-murphy]

keeping it optional kept the cast a bit nicer, but made usage awkward. i think i prefer the harder cast, and the easier usage. we don't have many examples in the codebase for this type of pattern.

[jason-ha]

Recommend using a type guard. Failing that an assert.
as is worse than ? IMO and as unknown as is generally terrible (prone to failure).
It is also good to have test code that is a good example of actual use and I don't think recommended pattern is as unknown as.

[anthony-murphy]

yeah. i'm not sure what the right pattern here is yet. i'd like to get this in, so i can see how it works

[Abe27342]

2c--when adding to some existing object type, exposing a typeguard also as part of the alpha API is pretty reasonable and gives customers a "safe" (at least as safe as we make it) way to use the APIs:

/**
 * @alpha @legacy
 */
export function asContainerRuntimeAlpha(runtime: IContainerRuntime): IContainerRuntimeAlpha {
    // whatever validation logic you want can replace
    return runtime as unknown as IContainerRuntimeAlpha;
}

[anthony-murphy]

#25509

[github-actions]

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output

> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  235713 links
    1720 destination URLs
    1953 URLs ignored
       0 warnings
       0 errors

[anthony-murphy]

I'd like this to make the release. since this is the alpha space, we can evolve the usage patterns as we figure them out

[anthony-murphy]

this changes as legacyAlpha.d.ts is the bottom most type def, from which all alpha legacies flow

[jason-ha]

The clean script needs updated to remove all generated files. I think just legacy/alpha.d.ts needs cleaned up now.