Skip to content

Remove JsonValidator export#25381

Merged
CraigMacomber merged 10 commits intomainfrom
RemoveJsonValidatorExport
Sep 26, 2025
Merged

Remove JsonValidator export#25381
CraigMacomber merged 10 commits intomainfrom
RemoveJsonValidatorExport

Conversation

@CraigMacomber
Copy link
Copy Markdown
Contributor

Description

Remove obsolete JsonValidator Alpha API in tree.

Breaking Changes

Users must migrate as described in changeset.

Reviewer Guidance

The review process is outlined on this wiki page.

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree area: dev experience Improving the experience of devs building on top of fluid area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct changeset-present public api change Changes to a public API base: main PRs targeted against main branch labels Sep 3, 2025
@CraigMacomber CraigMacomber marked this pull request as ready for review September 24, 2025 21:22
@CraigMacomber CraigMacomber requested review from a team as code owners September 24, 2025 21:22
Copilot AI review requested due to automatic review settings September 24, 2025 21:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the obsolete JsonValidator Alpha API from the tree package and replaces it with FormatValidator. The migration eliminates deprecated interfaces and consolidates validation to use the newer format validator pattern.

Key Changes

  • Removed JsonValidator, SchemaValidationFunction, noopValidator, and typeboxValidator Alpha APIs
  • Updated all code references to use FormatValidatorBasic instead of typeboxValidator
  • Replaced noopValidator with FormatValidatorNoOp throughout the codebase

Reviewed Changes

Copilot reviewed 40 out of 40 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/framework/fluid-framework/api-report/fluid-framework.alpha.api.md Removes deprecated JsonValidator types from public API
packages/dds/tree/api-report/tree.alpha.api.md Removes deprecated JsonValidator types from tree API
packages/dds/tree/src/codec/codec.ts Updates ICodecOptions to only accept FormatValidator, inlines noopValidator
packages/dds/tree/src/codec/noopValidator.ts Removes entire file containing deprecated validator
packages/dds/tree/src/external-utilities/typeboxValidator.ts Makes typeboxValidator private, keeps FormatValidatorBasic export
Multiple test files Updates all test code to use FormatValidatorBasic instead of typeboxValidator
Multiple source files Updates production code to use FormatValidatorNoOp instead of noopValidator

@github-actions github-actions bot removed the area: dev experience Improving the experience of devs building on top of fluid label Sep 25, 2025
@CraigMacomber
Copy link
Copy Markdown
Contributor Author

Attempting to re-trigger license/cla check

@github-actions
Copy link
Copy Markdown
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  236987 links
    1726 destination URLs
    1962 URLs ignored
       0 warnings
       0 errors


@CraigMacomber CraigMacomber merged commit 64a9b88 into main Sep 26, 2025
39 checks passed
@CraigMacomber CraigMacomber deleted the RemoveJsonValidatorExport branch September 26, 2025 18:26
anthony-murphy-agent pushed a commit to anthony-murphy-agent/FluidFramework that referenced this pull request Jan 14, 2026
## Description

Remove obsolete JsonValidator Alpha API in tree.

## Breaking Changes

Users must migrate as described in changeset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: dds: tree area: dds Issues related to distributed data structures area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch changeset-present public api change Changes to a public API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants