Merged
Conversation
zhangxin511
requested review from
Copilot and
znewton
and removed request for
Copilot
github-actions
bot
added
base: main
zhangxin511
commented
Sep 9, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds tracking of operation and signal counts per client session to improve telemetry data collection. The changes enable better monitoring of client activity by accumulating op and signal counts throughout a session and reporting them when sessions end.
Key changes:
- Add
sessionOpCountandsessionSignalCountfields to session telemetry properties - Track per-client operation and signal counts during active sessions
- Report accumulated metrics when clients disconnect and sessions end
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| server/routerlicious/packages/services-core/src/collabSession.ts | Add optional sessionOpCount and sessionSignalCount fields to telemetry properties interface |
| server/routerlicious/packages/services/src/sessionTracker.ts | Update session tracking to accumulate client metrics and report them in session end telemetry |
| server/routerlicious/packages/services/src/redisSessionManager.ts | Add Redis storage support for new session metric fields |
| server/routerlicious/packages/lambdas/src/nexus/index.ts | Track per-client operation and signal counts during message processing |
| server/routerlicious/packages/lambdas/src/nexus/disconnect.ts | Pass accumulated client metrics to session tracker when clients disconnect |
| server/routerlicious/packages/services-telemetry/src/resources.ts | Add CommonProperties enum values for session-level metrics |
| Test files | Add comprehensive test coverage for the new session metrics functionality |
znewton
approved these changes
Sep 10, 2025
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
## Description Add counters per session for submitted ops and signals, and collect these when cient leave. Aggregate to remote sessions and report when session considerd as inactivity ## Breaking Changes NA --------- Co-authored-by: Xin Zhang <zhangxin@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add counters per session for submitted ops and signals, and collect these when cient leave. Aggregate to remote sessions and report when session considerd as inactivity
Breaking Changes
NA