semantic-editing: Fix references in methods

[taylorsw04]

Description

This PR fixes a bug in which references to schema types in exposed methods would be converted to void in the types shown to the agent. It also cleans up some code and removes some unnecessary optimizations in the type string generation.

[Copilot]

Pull Request Overview

This PR fixes a bug where references to schema types in exposed methods would be converted to void in the types shown to agents. The fix involves updating the type generation system to properly track and include referenced types from method bindings. The changes also simplify the instanceOf utility by removing unnecessary caching optimizations.

• Fixes bug where method parameter/return types were being converted to void instead of preserving schema type references
• Removes caching optimization from instanceOf function and simplifies its implementation
• Updates the type generation system to track and include types referenced by exposed methods

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/framework/tree-agent/src/utils.ts	Removes caching from instanceOf function and adds error handling for unsupported zod effects
packages/framework/tree-agent/src/typeGeneration.ts	Updates type generation to track referenced types from methods and iterate over multiple schemas
packages/framework/tree-agent/src/test/systemPrompt.spec.ts	Adds test for method return types and refactors test helper
packages/framework/tree-agent/src/methodBinding.ts	Updates ExposedMethods interface to track referenced types and provides instanceOf method
packages/framework/tree-agent/src/index.ts	Removes instanceOf from exports
packages/framework/tree-agent/api-report/tree-agent.alpha.api.md	Updates API to reflect instanceOf removal from exports and BindableSchema type changes

[alexvy86]

Mostly mechanical comments. The overall idea makes sense, but I suggest waiting for @noencke to have a look too.

[github-actions]

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output

> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  235713 links
    1720 destination URLs
    1953 URLs ignored
       0 warnings
       0 errors

[noencke]

nit: Iterable<SimpleTreeSchema> is probably the "most correct" type here, but might just be simpler to use an array SimpleTreeSchema[] since it's common/familiar.