Skip to content

build(eslint-config-fluid): Update dependency on eslint-plugin-fluid#25490

Merged
Josmithr merged 8 commits intomicrosoft:mainfrom
Josmithr:eslint-config-fluid/update-fluid-plugin
Sep 22, 2025
Merged

build(eslint-config-fluid): Update dependency on eslint-plugin-fluid#25490
Josmithr merged 8 commits intomicrosoft:mainfrom
Josmithr:eslint-config-fluid/update-fluid-plugin

Conversation

@Josmithr
Copy link
Copy Markdown
Contributor

@Josmithr Josmithr commented Sep 18, 2025

Updates @fluid-internal/eslint-plugin-fluid from 0.1.5 to 0.2.0.

Enables the following new rules as warnings (they will be promoted to errors in the next major release):

  • @fluid-internal/fluid/no-file-path-links-in-jsdoc
  • @fluid-internal/fluid/no-markdown-links-in-jsdoc

@Josmithr Josmithr requested review from a team and Copilot September 18, 2025 23:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the ESLint configuration package to use a newer version of the Fluid ESLint plugin dependency.

  • Bumps @fluid-internal/eslint-plugin-fluid from version 0.1.5 to 0.1.6
  • Updates the package version to 6.0.2 to reflect the dependency change
  • Adds changelog entry documenting the dependency update

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
common/build/eslint-config-fluid/package.json Updates package version and eslint-plugin-fluid dependency version
common/build/eslint-config-fluid/CHANGELOG.md Adds changelog entry for version 6.0.2 with dependency update details
Files not reviewed (1)
  • common/build/eslint-config-fluid/pnpm-lock.yaml: Language not supported

@github-actions github-actions bot added area: build Build related issues base: main PRs targeted against main branch labels Sep 18, 2025
@Josmithr Josmithr enabled auto-merge (squash) September 18, 2025 23:53
Copy link
Copy Markdown
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the merge conflicts, should we wait until https://github.com/microsoft/FluidFramework/pull/25492/files is in, so we don't have to bump this again?

@Josmithr
Copy link
Copy Markdown
Contributor Author

Besides the merge conflicts, should we wait until https://github.com/microsoft/FluidFramework/pull/25492/files is in, so we don't have to bump this again?

I'm fine either way. Bumping the plugin package is pretty low friction since it only has 1 user.

@Josmithr Josmithr requested review from a team and alexvy86 September 19, 2025 23:57
@github-actions
Copy link
Copy Markdown
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  235713 links
    1720 destination URLs
    1953 URLs ignored
       0 warnings
       0 errors


@Josmithr Josmithr merged commit 7c74aaf into microsoft:main Sep 22, 2025
32 checks passed
@Josmithr Josmithr deleted the eslint-config-fluid/update-fluid-plugin branch November 14, 2025 23:09
anthony-murphy-agent pushed a commit to anthony-murphy-agent/FluidFramework that referenced this pull request Jan 14, 2026
microsoft#25490)

Updates `@fluid-tools/eslint-plugin-fluid` from `0.1.5` to `0.1.6`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: build Build related issues base: main PRs targeted against main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants