Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses assert tagging requirements by converting string literal error messages to hex codes in assert statements across multiple files. The changes also include cleanup of duplicate assert entries in the assertion short codes map.
- Replace string literal error messages with hex codes in assert statements following coding guidelines
- Remove duplicate entries from the assertion short codes map
- Add new hex code mappings for the converted assert statements
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/runtime/test-runtime-utils/src/assertionShortCodesMap.ts | Removes duplicate assert entries and adds new hex code mappings |
| packages/runtime/container-runtime/src/blobManager/blobManager.ts | Converts string literal assert to hex code 0xc53 |
| packages/dds/tree/src/simple-tree/core/treeNodeKernel.ts | Converts multiple string literal asserts to hex codes 0xc4f, 0xc50, 0xc51, 0xc52 |
| packages/dds/tree/src/simple-tree/api/dirtyIndex.ts | Converts string literal asserts to hex codes 0xc48-0xc4e |
| packages/dds/task-manager/src/taskManager.ts | Converts multiple string literal asserts to hex codes 0xc3b-0xc47 |
github-actions
bot
added
area: dds
jzaffiro
approved these changes
Sep 22, 2025
CraigMacomber
approved these changes
Sep 22, 2025
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
`pnpm run policy-check:asserts`. Fixing some duplicate asserts as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm run policy-check:asserts.Fixing some duplicate asserts as well.