Remove extra -- from pnpm exec scripts #25541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes incorrect usage of double hyphens (--) in pnpm exec commands. The double hyphens are unnecessary when passing arguments to pnpm exec scripts and have been removed.
- Removes extra
--separators from pnpm exec commands in pipeline templates - Affects telemetry generator and trips setup/cleanup commands
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/pipelines/templates/include-upload-stage-telemetry.yml | Removes extra -- from telemetry-generator commands |
| tools/pipelines/templates/include-test-real-service.yml | Removes extra -- from trips-setup and trips-cleanup commands |
github-actions
bot
added
area: build
jzaffiro
approved these changes
Sep 24, 2025
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
## Description Follow-up to microsoft#25535: this extra syntax is no longer required after moving off `npx` and though they are benign for me locally, they cause parameters to not be plumbed through in pipelines (likely due to shell differences) Test run: [here](https://dev.azure.com/fluidframework/internal/_build/results?buildId=357111&view=results) Co-authored-by: Abram Sanderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #25535: this extra syntax is no longer required after moving off
npxand though they are benign for me locally, they cause parameters to not be plumbed through in pipelines (likely due to shell differences)Test run: here