Use secondary repository checkout in performance benchmarks pipeline #25550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
September 25, 2025 10:25
…to test/absander/update-perf-benchmarks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the performance benchmarks pipeline template to use secondary repository checkout instead of downloading test artifacts to a separate workspace. It switches from npm/npx commands to pnpm commands and standardizes dependency installation using a new shared template.
- Switches from workspace-based test artifact extraction to source directory-based approach
- Replaces npm/npx commands with pnpm equivalents throughout the pipeline
- Consolidates dependency installation logic into reusable templates
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/pipelines/test-perf-benchmarks.yml | Updates test workspace paths, removes separate telemetry generator installation, switches to pnpm commands and shared dependency templates |
| tools/pipelines/templates/include-test-real-service.yml | Replaces inline devDependencies copying logic with shared template |
| tools/pipelines/templates/include-test-perf-benchmarks.yml | Adds secondary repository checkout, removes separate workspace setup, switches to pnpm and shared templates |
| tools/pipelines/templates/include-test-perf-benchmarks-install-package.yml | Changes npm install command to pnpm install |
| tools/pipelines/templates/include-setup-npmrc-for-download.yml | Renames parameter from npmrcLocation to userNpmrcDirectory for consistency |
| tools/pipelines/templates/include-install.yml | Adds primaryRegistry and userNpmrcPath parameters for better configuration |
| tools/pipelines/templates/include-copy-dev-dependencies.yml | New shared template that consolidates devDependencies copying logic |
github-actions
bot
added
area: build
jzaffiro
approved these changes
Sep 25, 2025
jzaffiro
approved these changes
Sep 26, 2025
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
…icrosoft#25550) ## Description Follow-up to microsoft#25535 which applies the same kind of change to the performance benchmarks pipeline template. Test run: [here](https://dev.azure.com/fluidframework/internal/_build/results?buildId=357522&view=results) --------- Co-authored-by: Abram Sanderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #25535 which applies the same kind of change to the performance benchmarks pipeline template.
Test run: here