Restore compat install caching to include-test-real-service.yaml #25563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
September 25, 2025 10:25
…to test/absander/update-perf-benchmarks
Contributor
Author
|
ah forgot I based this on another change. Will check that in first. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restores caching of compatibility version installations to the test pipeline and improves the caching mechanism with major+minor version-based cache keys. The changes consolidate dependency installation logic and switch from npm to pnpm across the pipeline templates.
Key changes:
- Restored caching for compatibility version installs with improved cache key strategy
- Standardized on pnpm instead of npm throughout pipeline templates
- Consolidated dependency installation logic into reusable templates
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/pipelines/test-perf-benchmarks.yml | Switches from npm to pnpm, removes workspace-related parameters, uses shared dependency template |
| tools/pipelines/templates/include-test-real-service.yml | Restores compat version caching with dynamic path resolution and major+minor cache key |
| tools/pipelines/templates/include-test-perf-benchmarks.yml | Removes workspace parameters, switches to pnpm, adds checkout step |
| tools/pipelines/templates/include-test-perf-benchmarks-install-package.yml | Changes npm install to pnpm install |
| tools/pipelines/templates/include-setup-npmrc-for-download.yml | Renames parameter from npmrcLocation to userNpmrcDirectory |
| tools/pipelines/templates/include-install.yml | Adds primaryRegistry and userNpmrcPath parameters |
| tools/pipelines/templates/include-copy-dev-dependencies.yml | New template consolidating devDependency copying logic |
| packages/test/test-end-to-end-tests/src/test/benchmark/.mocharc.*.cjs | Updates require paths to use package names instead of node_modules paths |
| packages/dds//src/test//.mocharc.cjs | Updates require paths to use package names instead of node_modules paths |
added 2 commits
September 26, 2025 10:57
jzaffiro
approved these changes
Sep 26, 2025
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
…rosoft#25563) ## Description Follow-up to microsoft#25535 which restores the caching of compat dependencies we previously had. Couldn't help myself from making a tweak so the cache key is invalidated on minor version change, which should give us better long-term behavior: the set of versions to install is dynamically computed based on roughly the current package version, so using major+minor here should be a net win as only roughly one build per release should need to install compat dependencies, after that they will be cached. --------- Co-authored-by: Abram Sanderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #25535 which restores the caching of compat dependencies we previously had. Couldn't help myself from making a tweak so the cache key is invalidated on minor version change, which should give us better long-term behavior: the set of versions to install is dynamically computed based on roughly the current package version, so using major+minor here should be a net win as only roughly one build per release should need to install compat dependencies, after that they will be cached.