Use TRIPS for odspdf stress runs #25599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
October 1, 2025 10:27
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the test infrastructure to support ODSP TRIPS tenants for odspdf stress runs by adding proper tenant type configuration and refactoring parameters for better clarity.
- Adds
odspTenantTypeparameter to distinguish between prod and dogfood ODSP tenants - Replaces hardcoded stage-based logic with explicit
lockBehaviorparameter - Updates TRIPS setup and cleanup commands to accept tenant type parameters
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/pipelines/test-real-service.yml | Adds repository reference and configures lock behavior and tenant types for test stages |
| tools/pipelines/test-real-service-stress.yml | Adds repository reference, configures tenant types for stress tests, and removes hardcoded stage variables |
| tools/pipelines/test-perf-benchmarks.yml | Adds repository reference for ff_pipeline_host |
| tools/pipelines/test-dds-stress.yml | Adds repository reference for ff_pipeline_host |
| tools/pipelines/templates/include-test-real-service.yml | Major refactoring to support parameterized tenant types and lock behavior instead of hardcoded stage logic |
Abe27342
commented
Oct 2, 2025
| - release/* | ||
| - main | ||
| - next | ||
| repositories: |
Contributor
Author
There was a problem hiding this comment.
Adding these blocks to the pipelines that use ff_pipeline_host allows proper testing of changes to that repo before we check them in, since it means you can queue one of these pipelines while referencing a specific branch in that repository rather than being forced to use main. This is similar to the kind of thing we do for selecting the specific run of 'Build - client packages' when queueing the secondary pipelines.
scarlettjlee
approved these changes
Oct 2, 2025
added 2 commits
October 2, 2025 10:39
scarlettjlee
approved these changes
Oct 2, 2025
Abe27342
added a commit
that referenced
this pull request
Oct 8, 2025
## Description #25599 updated the include-test-real-service template to use a repository reference rather than an explicit checkout. This reference needs to exist on all pipelines that use it, but this one was missed. Co-authored-by: Abram Sanderson <[email protected]>
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
## Description Updates `include-test-real-service` to support odspdf TRIPS tenants. I did some minor refactoring for parameter clarity while in the area. Test runs: - e2e tests before trips-setup package update in the host repo [here](https://dev.azure.com/fluidframework/internal/_build/results?buildId=358461&view=results) (unaffected, as it should be) - Stress run using updated trips-setup [here](https://dev.azure.com/fluidframework/internal/_build/results?buildId=358690&view=results) --------- Co-authored-by: Abram Sanderson <[email protected]>
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
## Description microsoft#25599 updated the include-test-real-service template to use a repository reference rather than an explicit checkout. This reference needs to exist on all pipelines that use it, but this one was missed. Co-authored-by: Abram Sanderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
include-test-real-serviceto support odspdf TRIPS tenants.I did some minor refactoring for parameter clarity while in the area.
Test runs: