Skip to content

build(client): bump eslint-config-fluid to v7#25694

Merged
tylerbutler merged 57 commits intomicrosoft:mainfrom
tylerbutler:eslint-import-upgrade-client-v7
Oct 29, 2025
Merged

build(client): bump eslint-config-fluid to v7#25694
tylerbutler merged 57 commits intomicrosoft:mainfrom
tylerbutler:eslint-import-upgrade-client-v7

Conversation

@tylerbutler
Copy link
Member

@tylerbutler tylerbutler commented Oct 15, 2025

Upgrades client to v7 of our lint config.

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: dds: tree area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file and removed area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: runtime Runtime related issues area: loader Loader related issues labels Oct 15, 2025
@tylerbutler tylerbutler requested a review from a team as a code owner October 28, 2025 21:43
@tylerbutler tylerbutler requested review from a team and Copilot and removed request for Copilot October 28, 2025 21:43
this.cell2 = createConnectedCell("cell2", this.containerRuntimeFactory);
}

/* eslint-disable @fluid-internal/fluid/no-hyphen-after-jsdoc-tag -- false positive */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been erring on the side of not using @inheritDoc comments for direct interface implementations anyways. Intellisense does better without them, and we don't export this code anyways (so no API docs consideration). Might be better to just remove these comments.

Copy link
Contributor

@Josmithr Josmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions and a couple of questions. Otherwise looks good to me.

Sad about all of the places we had to disable the no-hyphen-after-jsdoc-tag - wondering if we should disable that rule in our shared config until we've fixed the bugs.

Copilot AI review requested due to automatic review settings October 29, 2025 20:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the @fluidframework/eslint-config-fluid package from version ^6.1.0 to ^7.0.0 across the entire codebase. The major version bump brings new ESLint rules that necessitated code changes to address linting violations.

Key changes:

  • Upgraded @fluidframework/eslint-config-fluid from 6.1.0 to 7.0.0 in all package.json files and the pnpm lockfile
  • Added eslint-disable comments for a new rule @fluid-internal/fluid/no-hyphen-after-jsdoc-tag where JSDoc contains {@link} tags
  • Disabled @typescript-eslint/unbound-method in several packages experiencing crashes with the new rule version (AB#51780)
  • Fixed various type and coding issues surfaced by new linting rules (e.g., replacing Object with object, adding missing eslint-disable comments)

Reviewed Changes

Copilot reviewed 208 out of 209 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pnpm-lock.yaml Updated lockfile to reflect the eslint-config-fluid version bump and its dependencies
*/package.json (multiple) Updated devDependency for @fluidframework/eslint-config-fluid to ^7.0.0 across all packages
Various .eslintrc.cjs Disabled @typescript-eslint/unbound-method rule in packages experiencing crashes
Various source files Added eslint-disable comments for no-hyphen-after-jsdoc-tag rule around JSDoc with @link tags
Type fixes Changed Object to object, added missing type annotations, fixed deprecated ESLint rule suppressions
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@github-actions
Copy link
Contributor

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

 ELIFECYCLE  Command failed with exit code 1.

@tylerbutler tylerbutler requested review from a team and Josmithr October 29, 2025 21:18
@tylerbutler tylerbutler merged commit 95d9a0a into microsoft:main Oct 29, 2025
37 checks passed
@tylerbutler tylerbutler deleted the eslint-import-upgrade-client-v7 branch October 29, 2025 22:13
anthony-murphy-agent pushed a commit to anthony-murphy-agent/FluidFramework that referenced this pull request Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: dds: propertydds area: dds: sharedstring area: dds: tree area: dds Issues related to distributed data structures area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch dependencies Pull requests that update a dependency file public api change Changes to a public API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants