build(client): bump eslint-config-fluid to v7#25694
build(client): bump eslint-config-fluid to v7#25694tylerbutler merged 57 commits intomicrosoft:mainfrom
Conversation
This reverts commit 75b587d.
examples/utils/example-utils/src/containerViewRuntimeFactory.ts
Outdated
Show resolved
Hide resolved
| this.cell2 = createConnectedCell("cell2", this.containerRuntimeFactory); | ||
| } | ||
|
|
||
| /* eslint-disable @fluid-internal/fluid/no-hyphen-after-jsdoc-tag -- false positive */ |
There was a problem hiding this comment.
We've been erring on the side of not using @inheritDoc comments for direct interface implementations anyways. Intellisense does better without them, and we don't export this code anyways (so no API docs consideration). Might be better to just remove these comments.
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the @fluidframework/eslint-config-fluid package from version ^6.1.0 to ^7.0.0 across the entire codebase. The major version bump brings new ESLint rules that necessitated code changes to address linting violations.
Key changes:
- Upgraded
@fluidframework/eslint-config-fluidfrom 6.1.0 to 7.0.0 in all package.json files and the pnpm lockfile - Added eslint-disable comments for a new rule
@fluid-internal/fluid/no-hyphen-after-jsdoc-tagwhere JSDoc contains{@link}tags - Disabled
@typescript-eslint/unbound-methodin several packages experiencing crashes with the new rule version (AB#51780) - Fixed various type and coding issues surfaced by new linting rules (e.g., replacing
Objectwithobject, adding missing eslint-disable comments)
Reviewed Changes
Copilot reviewed 208 out of 209 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Updated lockfile to reflect the eslint-config-fluid version bump and its dependencies |
| */package.json (multiple) | Updated devDependency for @fluidframework/eslint-config-fluid to ^7.0.0 across all packages |
| Various .eslintrc.cjs | Disabled @typescript-eslint/unbound-method rule in packages experiencing crashes |
| Various source files | Added eslint-disable comments for no-hyphen-after-jsdoc-tag rule around JSDoc with @link tags |
| Type fixes | Changed Object to object, added missing type annotations, fixed deprecated ESLint rule suppressions |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
|
🔗 Found some broken links! 💔 Run a link check locally to find them. See linkcheck output |
Upgrades client to v7 of our lint config.