(compat) Removed deprecated properties from IContainerStorageService and IRuntimeStorageService #25700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: framework
Contributor
There was a problem hiding this comment.
Pull Request Overview
Removes previously deprecated members from IRuntimeStorageService and IContainerStorageService, finalizing the breaking change announced in 2.52.0. Supporting updates adjust type validation metadata, API reports, tests, and adapters to align with the leaner interfaces.
- Remove deprecated storage APIs (disposed, dispose, policies, snapshot/version APIs, createBlob, uploadSummaryWithContext, downloadSummary) from IRuntimeStorageService
- Remove deprecated disposed / dispose / downloadSummary from IContainerStorageService and update consuming code/tests
- Update type validation artifacts, API reports, and add a comprehensive new blob manager test suite
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/runtime/runtime-definitions/src/protocol.ts | Removes deprecated members from IRuntimeStorageService |
| packages/common/container-definitions/src/runtime.ts | Removes deprecated members from IContainerStorageService |
| *.generated.ts / package.json typeValidation blocks | Marks expected breaking type changes with @ts-expect-error and updates broken maps |
| api-report/*.api.md | Syncs API surface with removed members |
| containerStorageAdapter.ts / container.ts | Removes now-invalid downloadSummary and updates parameter types |
| storageServiceWithAttachBlobs.ts | Simplifies proxy to only support readBlob per new interface |
| deRehydrateContainerTests.spec.ts | Drops test depending on removed snapshot methods |
| blobHandles.spec.ts | Updates tests to use IContainerStorageService subset typings |
| blobManager.spec.ts | Adds extensive new test coverage for blob lifecycle scenarios |
| containerRuntime.spec.ts | Switches test storage mock to IContainerStorageService |
| .changeset/heavy-bugs-thank.md | Records breaking change announcement |
…and IRuntimeStorageService
agarwal-navin
force-pushed
the
test/breaks/client/2.70/cleanupStorageService
branch
from
c33f0a7 to
afb8f1c
Compare
tylerbutler
approved these changes
Oct 15, 2025
.changeset/heavy-bugs-thank.md
Outdated
| - `disposed` | ||
| - `dispose` | ||
|
|
||
| The deprecations were announced in release 2.52.0 [here](https://github.com/microsoft/FluidFramework/releases/tag/client_v2.52.0). |
Member
There was a problem hiding this comment.
Suggested change
| The deprecations were announced in release 2.52.0 [here](https://github.com/microsoft/FluidFramework/releases/tag/client_v2.52.0). | |
| The deprecations were announced in version [2.52.0](https://github.com/microsoft/FluidFramework/releases/tag/client_v2.52.0). |
.changeset/heavy-bugs-thank.md
Outdated
| "@fluidframework/runtime-definitions": minor | ||
| "__section": breaking | ||
| --- | ||
| Removed deprecated properties from "IRuntimeStorageService" and "IContainerStorageService" |
Member
There was a problem hiding this comment.
Suggested change
| Removed deprecated properties from "IRuntimeStorageService" and "IContainerStorageService" | |
| Deprecated properties have been removed from IRuntimeStorageService and IContainerStorageService |
.changeset/heavy-bugs-thank.md
Outdated
Comment on lines
10
to
18
| - `disposed` | ||
| - `dispose` | ||
| - `policies` | ||
| - `getSnapshotTree` | ||
| - `getSnapshot` | ||
| - `getVersions` | ||
| - `createBlob` | ||
| - `uploadSummaryWithContext` | ||
| - `downloadSummary` |
.changeset/heavy-bugs-thank.md
Outdated
Comment on lines
22
to
24
| - `downloadSummary` | ||
| - `disposed` | ||
| - `dispose` |
Member
There was a problem hiding this comment.
Suggested change
| - `downloadSummary` | |
| - `disposed` | |
| - `dispose` | |
| - `dispose` | |
| - `disposed` | |
| - `downloadSummary` |
Contributor
Author
|
Closing in favor of #25708 |
Contributor
Author
|
@tylerbutler FYI, I closed this in favor of #25708 since I created the test branch in my fork instead of the main repo. |
agarwal-navin
deleted the
test/breaks/client/2.70/cleanupStorageService
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed deprecated properties from "IRuntimeStorageService" and "IContainerStorageService"
The following deprecated properties have been removed from
IRuntimeStorageService:disposeddisposepoliciesgetSnapshotTreegetSnapshotgetVersionscreateBlobuploadSummaryWithContextdownloadSummaryThe following deprecated properties have been removed from
IContainerStorageService:downloadSummarydisposeddisposeBreaking Changes
This is a breaking change. The deprecations were announced in release 2.52.0 here.