Create odsp-client-specific fluidcontainer interface#25727
Merged
znewton merged 5 commits intomicrosoft:mainfrom Oct 30, 2025
Merged
Create odsp-client-specific fluidcontainer interface#25727znewton merged 5 commits intomicrosoft:mainfrom
znewton merged 5 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new IOdspFluidContainer interface that extends the standard IFluidContainer to accommodate ODSP-specific behavior. The main purpose is to properly type the attach method override that already exists in OdspClient, which uses OdspContainerAttachProps instead of the standard ContainerAttachProps.
Key changes:
- Creates
IOdspFluidContainerinterface extendingIFluidContainerwith an overriddenattachmethod signature - Updates return types in
OdspClientmethods fromIFluidContainertoIOdspFluidContainer - Removes type casting by properly typing the generic parameters
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/service-clients/odsp-client/src/interfaces.ts | Adds new IOdspFluidContainer interface with ODSP-specific attach method signature |
| packages/service-clients/odsp-client/src/odspClient.ts | Updates return types to use IOdspFluidContainer and adds generic type parameters to eliminate type casts |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
🔗 Found some broken links! 💔 Run a link check locally to find them. See linkcheck output |
Josmithr
reviewed
Oct 30, 2025
Josmithr
approved these changes
Oct 30, 2025
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
## Description microsoft#25597 includes several changes that require exposing a slightly different, ODSPClient-specific `IFluidContainer` that exposes container methods like `serialize` and `uploadBlob`. Additionally, ODSPClient already returns a customized version of `FluidContainer` with an overwritten `attach` method, but the param types are not represented in the standard IFluidContainer type. ## Breaking Changes None. ## Reviewer Guidance For examples of how this interface will be extended, see microsoft#25597. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#25597 includes several changes that require exposing a slightly different, ODSPClient-specific
IFluidContainerthat exposes container methods likeserializeanduploadBlob. Additionally, ODSPClient already returns a customized version ofFluidContainerwith an overwrittenattachmethod, but the param types are not represented in the standard IFluidContainer type.Breaking Changes
None. The types introduced here are accurate to the existing types returned by OdspClient, but now they are explicitly specified.
Reviewer Guidance
For examples of how this interface will be extended, see #25597.