Skip to content

Conversation

@jason-ha
Copy link
Contributor

remove FluidDataStoreRuntime.submitMessage and MockFluidDataStoreRuntime.submitMessage

…Runtime.submitMessage

and MockFluidDataStoreRuntime.submitMessage
@jason-ha jason-ha requested review from a team as code owners October 25, 2025 06:47
@jason-ha jason-ha added the release-blocking Must be addressed before we cut and publish the next release label Oct 25, 2025
Copilot AI review requested due to automatic review settings October 25, 2025 06:47
@github-actions github-actions bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: runtime Runtime related issues changeset-present public api change Changes to a public API labels Oct 25, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated submitMessage method from both FluidDataStoreRuntime and MockFluidDataStoreRuntime classes, marking a breaking change. Users should migrate to using IFluidDataStoreContext.submitMessage instead.

Key Changes:

  • Removal of deprecated submitMessage methods from production and test runtime classes
  • Updates to type validation configuration to mark backward compatibility as broken
  • Addition of changeset documenting the breaking change

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/runtime/datastore/src/dataStoreRuntime.ts Removes the deprecated submitMessage method from FluidDataStoreRuntime
packages/runtime/test-runtime-utils/src/mocks.ts Removes the deprecated submitMessage method from MockFluidDataStoreRuntime
packages/runtime/datastore/api-report/datastore.legacy.beta.api.md Updates API report to reflect removal of submitMessage from public API
packages/runtime/test-runtime-utils/api-report/test-runtime-utils.legacy.beta.api.md Updates API report to reflect removal of submitMessage from mock runtime
packages/runtime/datastore/package.json Marks FluidDataStoreRuntime class backward compatibility as broken
packages/runtime/test-runtime-utils/package.json Marks MockFluidDataStoreRuntime class backward compatibility as broken
packages/runtime/datastore/src/test/types/validateDatastorePrevious.generated.ts Adds TypeScript error suppression for expected breaking compatibility
packages/runtime/test-runtime-utils/src/test/types/validateTestRuntimeUtilsPrevious.generated.ts Adds TypeScript error suppression for expected breaking compatibility
packages/framework/aqueduct/src/test/types/validateAqueductPrevious.generated.ts Adds TypeScript error suppression for transitive breaking compatibility
packages/framework/aqueduct/package.json Marks DataObjectFactoryProps interface backward compatibility as broken
.changeset/odd-loops-flash.md Documents the breaking change with migration guidance

@github-actions github-actions bot added the base: main PRs targeted against main branch label Oct 25, 2025
"@fluidframework/test-runtime-utils": minor
"__section": breaking
---
Remove submitMessage from FluidDataStoreRuntime and MockFluidDataStoreRuntime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'submitMessage'?

@github-actions
Copy link
Contributor

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

 ELIFECYCLE  Command failed with exit code 1.

Copy link
Contributor

@noencke noencke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped for API

@jason-ha jason-ha merged commit 88860f3 into main Oct 27, 2025
50 checks passed
@jason-ha jason-ha deleted the test/client/ops/remove-submitMessage-DataStoreRuntime branch October 27, 2025 16:45
anthony-murphy-agent pushed a commit to anthony-murphy-agent/FluidFramework that referenced this pull request Jan 14, 2026
…Runtime.submitMessage (microsoft#25755)

remove FluidDataStoreRuntime.submitMessage and
MockFluidDataStoreRuntime.submitMessage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: runtime Runtime related issues base: main PRs targeted against main branch changeset-present public api change Changes to a public API release-blocking Must be addressed before we cut and publish the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate/remove submitMessage on FluidDataStoreRuntime and MockFluidDataStoreRuntime

4 participants