fix(client-loader): recognize early local signals#25778
Merged
jason-ha merged 2 commits intomicrosoft:mainfrom Oct 30, 2025
Merged
fix(client-loader): recognize early local signals#25778jason-ha merged 2 commits intomicrosoft:mainfrom
jason-ha merged 2 commits intomicrosoft:mainfrom
Conversation
Use signal audience when available to correctly classify pre-Connected, local signals as local.
github-actions
bot
added
area: loader
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the signal processing logic to more accurately determine whether a signal is "local" (sent by the current client). The change addresses early signal detection during the connection lifecycle.
Key Changes
- Modified the
processSignalmethod to check againstsignalAudiencefor detecting current signals, including those arriving before the container reaches "Connected" state - Retained the original check against
this.clientIdas a fallback for detecting signals from past connections
WillieHabi
approved these changes
Oct 30, 2025
plus comment update
WillieHabi
approved these changes
Oct 30, 2025
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
Use signal audience to correctly classify pre-Connected, local signals as local.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use signal audience to correctly classify pre-Connected, local signals as local.