test(client-azure-end-to-end): fix Azure connect timeouts#25781
Merged
jason-ha merged 2 commits intomicrosoft:mainfrom Oct 31, 2025
Merged
test(client-azure-end-to-end): fix Azure connect timeouts#25781jason-ha merged 2 commits intomicrosoft:mainfrom
jason-ha merged 2 commits intomicrosoft:mainfrom
Conversation
allow more time for connecting to real AFR service in Presence tests. Change from a fixed 10s to dynamic time based on number of clients. Additionally changes: - output timestamp under verbose logging - send along or request and show log if connect times out
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves timeout handling and debugging capabilities in multiprocess end-to-end tests for Azure client presence functionality. The changes address test reliability issues by adjusting timeout values and adding better error context when connections fail.
- Increased Azure timeout multiplier from 3 to 5
- Added explicit test case timeouts based on child connection timeout expectations
- Enhanced error messages with diagnostic information (logs) when connection failures occur
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| presenceTest.spec.ts | Increased Azure timeout multiplier to 5 and added explicit test case timeouts for two test suites |
| orchestratorUtils.ts | Added connectTimeoutMs parameter to connection messages and debug reporting on first child connection failure |
| messageTypes.ts | Made connectTimeoutMs a required field in the ConnectCommand interface |
| childClient.tool.ts | Removed hardcoded timeout constant, improved logging with timestamps, and enhanced error messages with diagnostic logs |
...ges/service-clients/end-to-end-tests/azure-client/src/test/multiprocess/presenceTest.spec.ts
Outdated
Show resolved
Hide resolved
...ges/service-clients/end-to-end-tests/azure-client/src/test/multiprocess/presenceTest.spec.ts
Outdated
Show resolved
Hide resolved
and allow even more time for connecting to real AFR service in Presence tests. Output beforeEach completion time
scottn12
approved these changes
Oct 31, 2025
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
…25781) allow more time for connecting to real AFR service in Presence tests. Change from a fixed 10s to dynamic time based on number of clients. Additionally changes: - fix `beforeEach` cross contamination from different client counts by injected a `describe` block within loop body - output `beforeEach` completion time (otherwise untracked from mocha output) - output timestamp under verbose logging - send along or request and show log if connect times out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow more time for connecting to real AFR service in Presence tests.
Change from a fixed 10s to dynamic time based on number of clients.
Additionally changes:
beforeEachcross contamination from different client counts by injected adescribeblock within loop bodybeforeEachcompletion time (otherwise untracked from mocha output)