Skip to content

build(client): pin typescript version #25789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

build(client): pin typescript version #25789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8700817
build(client): pin typescript version
jason-ha Oct 31, 2025
f545e8a
ci(client): check for stable deduped lockfile
jason-ha Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,7 @@
"pnpm": {
"comments": [
"node types < 18 are bumped to use the latest 18.x types. Though we don't support 18, old deps that still depend on old type versions will be guaranteed to be working with the correct types for the node version they target.",
"cosmiconfig and ts-api-utils help pnpm dedupe stability required when eslint plugins may float typescript resolution up to later versions and then generate incorrect errors under eslint.",
"nodegit is replaced with an empty package here because it's currently only used by good-fences for features we do not need, and has issues building when changing node versions. See https://github.com/smikula/good-fences/issues/105 for details.",
"node types >= 22 are bumped down to 20.x to work around issues with packages using different types.",
"codemirror and marked overrides are because simplemde use * versions, and the fully up to date versions of its deps do not work. packageExtensions was tried to fix this, but did not work.",
Expand All @@ -364,6 +365,8 @@
"overrides": {
"@types/node@<18": "^18.19.0",
"@types/node@>=22": "^20.0.0",
"cosmiconfig>typescript": "$typescript",
"ts-api-utils>typescript": "$typescript",
"good-fences>nodegit": "npm:[email protected]",
"qs": "^6.11.0",
"simplemde>codemirror": "^5.65.11",
Expand Down
Loading
Loading