Skip to content

Conversation

@znewton
Copy link
Contributor

@znewton znewton commented Nov 4, 2025

Description

Portion of #25597 to expose container.uploadBlob via OdspClient's OdspFluidContainer.

Reviewer Guidance

Advice on tests/docs necessary to alter the beta API in this way would be appreciated.

@znewton znewton requested a review from a team as a code owner November 4, 2025 00:52
Copilot AI review requested due to automatic review settings November 4, 2025 00:52
@znewton znewton marked this pull request as draft November 4, 2025 00:52
@github-actions github-actions bot added public api change Changes to a public API base: main PRs targeted against main branch labels Nov 4, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the uploadBlob method to the IOdspFluidContainer interface, enabling blob upload functionality for ODSP containers. It also introduces runtime validation to ensure that returned containers are internal FluidContainer instances.

  • Adds uploadBlob method signature to the IOdspFluidContainer interface
  • Introduces isInternalFluidContainer checks in container creation and retrieval methods
  • Updates API reports to reflect the new public API surface

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/service-clients/odsp-client/src/odspClient.ts Adds isInternalFluidContainer import and validation checks in getContainer and createFluidContainer methods
packages/service-clients/odsp-client/src/interfaces.ts Adds uploadBlob method to the IOdspFluidContainer interface with documentation
packages/service-clients/odsp-client/api-report/odsp-client.beta.api.md Updates API surface to include the new uploadBlob method
packages/service-clients/odsp-client/api-report/odsp-client.alpha.api.md Updates API surface to include the new uploadBlob method

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

 ELIFECYCLE  Command failed with exit code 1.

@znewton znewton marked this pull request as ready for review November 11, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

base: main PRs targeted against main branch public api change Changes to a public API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant