Build: Fix for erroneous lint failure on @typescript-eslint/unbound-method rule

[TommyBrosman]

#25801 introduced an ESLint failure. This PR is the result of running pnpm dedupe on that revision. The failure takes the form of this error:

@fluidframework/driver-web-cache: ESLint: 8.57.1
@fluidframework/driver-web-cache:
@fluidframework/driver-web-cache: TypeError: Cannot read properties of undefined (reading 'kind')
@fluidframework/driver-web-cache: Occurred while linting D:\FluidFramework\packages\drivers\driver-web-cache\src\FluidCache.ts:257
@fluidframework/driver-web-cache: Rule: "@typescript-eslint/unbound-method"
@fluidframework/driver-web-cache:     at checkIfMethod (D:\FluidFramework\node_modules\.pnpm\@typescript-eslint+eslint-p_8b9c4a874c8369e3aeb983128d84ae5e\node_modules\@typescript-eslint\eslint-plugin\dist\rules\unbound-method.js:251:26)
@fluidframework/driver-web-cache:     at checkIfMethodAndReport (D:\FluidFramework\node_modules\.pnpm\@typescript-eslint+eslint-p_8b9c4a874c8369e3aeb983128d84ae5e\node_modules\@typescript-eslint\eslint-plugin\dist\rules\unbound-method.js:133:53)
@fluidframework/driver-web-cache:     at MemberExpression (D:\FluidFramework\node_modules\.pnpm\@typescript-eslint+eslint-p_8b9c4a874c8369e3aeb983128d84ae5e\node_modules\@typescript-eslint\eslint-plugin\dist\rules\unbound-method.js:173:17)
@fluidframework/driver-web-cache:     at ruleErrorHandler (D:\FluidFramework\node_modules\.pnpm\eslint@8.57.1\node_modules\eslint\lib\linter\linter.js:1076:28)
@fluidframework/driver-web-cache:     at D:\FluidFramework\node_modules\.pnpm\eslint@8.57.1\node_modules\eslint\lib\linter\safe-emitter.js:45:58
@fluidframework/driver-web-cache:     at Array.forEach (<anonymous>)
@fluidframework/driver-web-cache:     at Object.emit (D:\FluidFramework\node_modules\.pnpm\eslint@8.57.1\node_modules\eslint\lib\linter\safe-emitter.js:45:38)
@fluidframework/driver-web-cache:     at NodeEventGenerator.applySelector (D:\FluidFramework\node_modules\.pnpm\eslint@8.57.1\node_modules\eslint\lib\linter\node-event-generator.js:297:26)
@fluidframework/driver-web-cache:     at NodeEventGenerator.applySelectors (D:\FluidFramework\node_modules\.pnpm\eslint@8.57.1\node_modules\eslint\lib\linter\node-event-generator.js:326:22)
@fluidframework/driver-web-cache:     at NodeEventGenerator.enterNode (D:\FluidFramework\node_modules\.pnpm\eslint@8.57.1\node_modules\eslint\lib\linter\node-event-generator.js:340:14)

[Copilot]

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

[CraigMacomber]

The error you are fixing can be fixed by deleting your node_modules and reinstalling. Making a PR that happens to make a change which causes some things to be reinstalled might happen to have fixed it for you as well, but I suspect it's not sure this error is less likely to occur with the lock file changes you are proposing.

That said, I think this is a good change, keeping things deduped is nice, but I think the claim for what it fixes in the description might not be accurate

[alexvy86]

The error you are fixing can be fixed by deleting your node_modules and reinstalling. Making a PR that happens to make a change which causes some things to be reinstalled might happen to have fixed it for you as well, but I suspect it's not sure this error is less likely to occur with the lock file changes you are proposing.

That said, I think this is a good change, keeping things deduped is nice, but I think the claim for what it fixes in the description might not be accurate

I think @TommyBrosman did try reinstalling after cleaning up node_modules and it didn't help; it does seem like a different issue from the one that manifests as eslint rules not being found that has been discussed in some other channels.

[TommyBrosman]

This issue was addressed by #25774.