test(build-tools): remove eslint-config-fluid from tests#25822
Merged
tylerbutler merged 1 commit intomicrosoft:mainfrom Nov 6, 2025
Merged
test(build-tools): remove eslint-config-fluid from tests#25822tylerbutler merged 1 commit intomicrosoft:mainfrom
tylerbutler merged 1 commit intomicrosoft:mainfrom
Conversation
github-actions
bot
added
area: build
tylerbutler
changed the title
tylerbutler
changed the title
tylerbutler
commented
Nov 5, 2025
Comment on lines
+169
to
+174
| "onlyBuiltDependencies": [ | ||
| "@biomejs/biome", | ||
| "core-js", | ||
| "es5-ext", | ||
| "sharp", | ||
| "unrs-resolver" |
Member
Author
There was a problem hiding this comment.
could have sworn I already did this...
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes two changes related to package management and testing: (1) temporarily disables a test expectation for eslint-config-fluid due to its relocation to the client release group, and (2) adds a new onlyBuiltDependencies configuration for pnpm to specify dependencies that should only be installed from pre-built packages.
- Commented out test expectation for
@fluidframework/eslint-config-fluidpending its move from client release group - Added
onlyBuiltDependenciespnpm configuration to control build-from-source behavior for specific dependencies
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| build-tools/packages/build-cli/src/test/filter.test.ts | Temporarily disables test assertion checking for eslint-config-fluid package in independent packages selection test |
| build-tools/package.json | Adds onlyBuiltDependencies configuration to pnpm settings with 5 packages that should only use pre-built versions |
Comment on lines
+173
to
+174
| "sharp", | ||
| "unrs-resolver" |
There was a problem hiding this comment.
The package name 'unrs-resolver' appears to be a typo. This package name does not exist in the npm registry. Did you mean 'unres-resolver' or another package?
Suggested change
| "sharp", | |
| "unrs-resolver" | |
| "sharp" |
alexvy86
approved these changes
Nov 5, 2025
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
…5822) Remove eslint-config-fluid from the test in build-tools. Can be added back once eslint-config-fluid is out of the client release group. Also opportunistically approves some dep postinstalls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove eslint-config-fluid from the test in build-tools. Can be added back once eslint-config-fluid is out of the client release group.
Also opportunistically approves some dep postinstalls.