Better document lowestMinVersionForCollab, and set to 1.4 #25824
+31
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: runtime
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the minimum supported version for collaboration from 1.0.0 to 1.4.0 to align with the actual supported version policy. The change reflects that versions below 1.4.0 were no longer supported at the time of the 2.0 release.
- Bumped
lowestMinVersionForCollabconstant from"1.0.0"to"1.4.0" - Enhanced documentation explaining the rationale for supporting 1.4.0 as the minimum version
- Updated comments to provide guidance for future major version releases
Co-authored-by: Copilot <[email protected]>
Contributor
|
@scottn12 FYI. I think it makes to set this to 1.4. I am not aware that we had promised any more support than this with 2.0. |
Contributor
Yeah I think we had considered 1.4 previously as well. It should be fine and there really shouldn't be any clients that exist today older than 1.4 |
Co-authored-by: yann-achard-MS <[email protected]>
…to lowestMinVersionForCollab1.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I don't find the documentation for lowestMinVersionForCollab particularly informative, nor do I think the approach it describes is the best one.
This attempts to establish a practical process for how it should be set which minimizes the support obligation each major will incur while keeping the required ability to collab with all previously supported major versions.
Reviewer Guidance
The review process is outlined on this wiki page.