Skip to content

Revert "build(client): Move eslint-config-fluid to client release group"#25827

Closed
alexvy86 wants to merge 1 commit intomainfrom
revert-25806-eslint-config-client-merge
Closed

Revert "build(client): Move eslint-config-fluid to client release group"#25827
alexvy86 wants to merge 1 commit intomainfrom
revert-25806-eslint-config-client-merge

Conversation

@alexvy86
Copy link
Contributor

@alexvy86 alexvy86 commented Nov 6, 2025

Reverts #25806. The performance benchmarks pipeline broke because of it.

Copilot AI review requested due to automatic review settings November 6, 2025 15:05
@github-actions github-actions bot added area: build Build related issues area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: dds: tree area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Nov 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes @fluidframework/eslint-config-fluid from the client release group, making it an independently published package. The main changes include:

  • Converting the package from a private workspace package (version 2.72.0) to a public npm package (version 8.1.0)
  • Updating all workspace references (workspace:^) to the published version (^8.1.0)
  • Removing the package from the pnpm workspace and client build pipeline triggers
  • Re-enabling package building and publishing tasks
  • Updating package dependencies to newer versions of eslint plugins

Reviewed Changes

Copilot reviewed 166 out of 168 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tools/pipelines/build-eslint-config-fluid.yml Re-enabled taskPack for independent publishing
tools/pipelines/build-client.yml Removed eslint-config-fluid from build triggers
syncpack.config.cjs Removed ESLint-related patterns from tilde ranges and enabled eslint-config-fluid in local package checks
pnpm-workspace.yaml Removed common/build/eslint-config-fluid from workspace
pnpm-lock.yaml Updated all references from workspace links to version 8.1.0
common/build/eslint-config-fluid/package.json Changed from private package v2.72.0 to public v8.1.0, updated dependencies and scripts
fluidBuild.config.cjs Removed eslint-config-fluid from independent packages and npm-private-packages exclusions
100+ package.json files Updated eslint-config-fluid from workspace:^ to ^8.1.0
Files not reviewed (1)
  • common/build/eslint-config-fluid/pnpm-lock.yaml: Language not supported

Comment on lines 122 to 123
"eslint-plugin-*",
"eslint-config-prettier",
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing the ESLint-related patterns from lines 122-126 in the previous location, eslint-config-prettier appears twice in the list (line 123 and originally elsewhere). This duplication is redundant and should be removed to maintain clean configuration.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

 ELIFECYCLE  Command failed with exit code 1.

@alexvy86
Copy link
Contributor Author

alexvy86 commented Nov 6, 2025

We fixed the pipeline with #25828. Closing this.

@alexvy86 alexvy86 closed this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: build Build related issues area: dds: propertydds area: dds: sharedstring area: dds: tree area: dds Issues related to distributed data structures area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants