Revert "build(client): Move eslint-config-fluid to client release group"#25827
Revert "build(client): Move eslint-config-fluid to client release group"#25827
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes @fluidframework/eslint-config-fluid from the client release group, making it an independently published package. The main changes include:
- Converting the package from a private workspace package (version 2.72.0) to a public npm package (version 8.1.0)
- Updating all workspace references (
workspace:^) to the published version (^8.1.0) - Removing the package from the pnpm workspace and client build pipeline triggers
- Re-enabling package building and publishing tasks
- Updating package dependencies to newer versions of eslint plugins
Reviewed Changes
Copilot reviewed 166 out of 168 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/pipelines/build-eslint-config-fluid.yml | Re-enabled taskPack for independent publishing |
| tools/pipelines/build-client.yml | Removed eslint-config-fluid from build triggers |
| syncpack.config.cjs | Removed ESLint-related patterns from tilde ranges and enabled eslint-config-fluid in local package checks |
| pnpm-workspace.yaml | Removed common/build/eslint-config-fluid from workspace |
| pnpm-lock.yaml | Updated all references from workspace links to version 8.1.0 |
| common/build/eslint-config-fluid/package.json | Changed from private package v2.72.0 to public v8.1.0, updated dependencies and scripts |
| fluidBuild.config.cjs | Removed eslint-config-fluid from independent packages and npm-private-packages exclusions |
| 100+ package.json files | Updated eslint-config-fluid from workspace:^ to ^8.1.0 |
Files not reviewed (1)
- common/build/eslint-config-fluid/pnpm-lock.yaml: Language not supported
| "eslint-plugin-*", | ||
| "eslint-config-prettier", |
There was a problem hiding this comment.
After removing the ESLint-related patterns from lines 122-126 in the previous location, eslint-config-prettier appears twice in the list (line 123 and originally elsewhere). This duplication is redundant and should be removed to maintain clean configuration.
|
🔗 Found some broken links! 💔 Run a link check locally to find them. See linkcheck output |
|
We fixed the pipeline with #25828. Closing this. |
Reverts #25806. The performance benchmarks pipeline broke because of it.