Skip to content

build(client): upgrade eslint deps with bulk suppressions #26082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tylerbutler wants to merge 12 commits into from
Closed

build(client): upgrade eslint deps with bulk suppressions #26082

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8e32a3c
upgrade eslint deps
tylerbutler Dec 16, 2025
b0901dc
pre-fix lint issues
tylerbutler Dec 16, 2025
0255cc7
Merge branch 'main' into upgrade-typescript-eslint
tylerbutler Dec 18, 2025
edd15be
syncpack
tylerbutler Dec 18, 2025
c263683
Revert "pre-fix lint issues"
tylerbutler Dec 18, 2025
4017a5d
inline suppressions
tylerbutler Dec 18, 2025
1db462e
rm inline exclusions
tylerbutler Dec 18, 2025
4add50c
add suppressions files
tylerbutler Dec 18, 2025
7d1a497
policy
tylerbutler Dec 18, 2025
050bd4d
Update common/build/eslint-config-fluid/package.json
tylerbutler Dec 18, 2025
d83b547
Merge branch 'main' into upgrade-typescript-eslint
tylerbutler Dec 18, 2025
e77c056
Merge branch 'main' into upgrade-typescript-eslint
tylerbutler Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions common/build/eslint-config-fluid/flat.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,14 @@ minimalDeprecated.push(dependConfig);
// Note: tsconfigRootDir is not set here to allow the parser to discover the correct project root
// from the location of the file being linted. This also allows the tsdoc plugin to find tsdoc.json
// files in the correct location.
// Note: project is explicitly set to null to override the project setting from the base eslintrc
// config (via FlatCompat). Newer @typescript-eslint/parser versions error if both project and
// projectService are enabled.
const useProjectService = {
files: ["**/*.ts", "**/*.tsx", "**/*.mts", "**/*.cts"],
languageOptions: {
parserOptions: {
project: null,
projectService: true,
},
},
Expand Down
12 changes: 6 additions & 6 deletions common/build/eslint-config-fluid/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,19 @@
"dependencies": {
"@eslint-community/eslint-plugin-eslint-comments": "~4.5.0",
"@eslint/eslintrc": "^3.3.3",
"@eslint/js": "^8.57.1",
"@eslint/js": "^9.39.2",
"@fluid-internal/eslint-plugin-fluid": "^0.4.1",
"@rushstack/eslint-plugin": "~0.22.1",
"@typescript-eslint/eslint-plugin": "~8.18.2",
"@typescript-eslint/parser": "~8.18.2",
"@typescript-eslint/eslint-plugin": "~8.50.0",
"@typescript-eslint/parser": "~8.50.0",
"eslint-config-biome": "~2.1.3",
"eslint-config-prettier": "~10.1.8",
"eslint-import-resolver-typescript": "~4.4.4",
"eslint-plugin-depend": "~1.4.0",
"eslint-plugin-import-x": "~4.16.1",
"eslint-plugin-jsdoc": "~61.4.1",
"eslint-plugin-jsdoc": "~61.5.0",
"eslint-plugin-promise": "~7.2.1",
"eslint-plugin-react": "~7.35.0",
"eslint-plugin-react": "~7.37.5",
"eslint-plugin-react-hooks": "~7.0.1",
"eslint-plugin-tsdoc": "~0.5.0",
"eslint-plugin-unicorn": "~54.0.0",
Expand All @@ -57,7 +57,7 @@
"tsx": "^4.21.0",
"typescript": "~5.4.5"
},
"packageManager": "[email protected]+sha512.bbd16e6d7286fd7e01f6b3c0b3c932cda2965c06a908328f74663f10a9aea51f1129eea615134bf992831b009eabe167ecb7008b597f40ff9bc75946aadfb08d",
"packageManager": "[email protected]",
"fluidBuild": {
"tasks": {
"prettier": {
Expand Down
288 changes: 156 additions & 132 deletions common/build/eslint-config-fluid/pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

20 changes: 11 additions & 9 deletions common/build/eslint-config-fluid/printed-configs/default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"plugins": [
"@",
"@eslint-community/eslint-comments",
"@typescript-eslint:@typescript-eslint/eslint-plugin@8.18.2",
"@typescript-eslint:@typescript-eslint/eslint-plugin@8.50.0",
"import-x:[email protected]",
"unicorn:[email protected]",
"@rushstack",
Expand Down Expand Up @@ -1401,6 +1401,9 @@
"no-const-assign": [
"off"
],
"no-constant-binary-expression": [
"error"
],
"no-constant-condition": [
"error",
{
Expand Down Expand Up @@ -1459,6 +1462,9 @@
"allowObjectPatternsAsParameters": false
}
],
"no-empty-static-block": [
"error"
],
"no-eval": [
"error",
{
Expand Down Expand Up @@ -1503,13 +1509,6 @@
"no-import-assign": [
"off"
],
"no-inner-declarations": [
"error",
"functions",
{
"blockScopedFunctions": "allow"
}
],
"no-invalid-regexp": [
"error",
{}
Expand Down Expand Up @@ -1734,6 +1733,9 @@
"no-unused-labels": [
"error"
],
"no-unused-private-class-members": [
"error"
],
"no-unused-vars": [
"off"
],
Expand Down Expand Up @@ -1762,7 +1764,7 @@
"off"
],
"no-with": [
"error"
"off"
],
"no-wrap-func": [
"off"
Expand Down
20 changes: 11 additions & 9 deletions common/build/eslint-config-fluid/printed-configs/minimal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"plugins": [
"@",
"@eslint-community/eslint-comments",
"@typescript-eslint:@typescript-eslint/eslint-plugin@8.18.2",
"@typescript-eslint:@typescript-eslint/eslint-plugin@8.50.0",
"import-x:[email protected]",
"unicorn:[email protected]",
"@rushstack",
Expand Down Expand Up @@ -1368,6 +1368,9 @@
"no-const-assign": [
"off"
],
"no-constant-binary-expression": [
"error"
],
"no-constant-condition": [
"error",
{
Expand Down Expand Up @@ -1426,6 +1429,9 @@
"allowObjectPatternsAsParameters": false
}
],
"no-empty-static-block": [
"error"
],
"no-eval": [
"error",
{
Expand Down Expand Up @@ -1470,13 +1476,6 @@
"no-import-assign": [
"off"
],
"no-inner-declarations": [
"error",
"functions",
{
"blockScopedFunctions": "allow"
}
],
"no-invalid-regexp": [
"error",
{}
Expand Down Expand Up @@ -1698,6 +1697,9 @@
"no-unused-labels": [
"error"
],
"no-unused-private-class-members": [
"error"
],
"no-unused-vars": [
"off"
],
Expand Down Expand Up @@ -1726,7 +1728,7 @@
"off"
],
"no-with": [
"error"
"off"
],
"no-wrap-func": [
"off"
Expand Down
20 changes: 11 additions & 9 deletions common/build/eslint-config-fluid/printed-configs/react.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"plugins": [
"@",
"@eslint-community/eslint-comments",
"@typescript-eslint:@typescript-eslint/eslint-plugin@8.18.2",
"@typescript-eslint:@typescript-eslint/eslint-plugin@8.50.0",
"import-x:[email protected]",
"unicorn:[email protected]",
"@rushstack",
Expand Down Expand Up @@ -1403,6 +1403,9 @@
"no-const-assign": [
"off"
],
"no-constant-binary-expression": [
"error"
],
"no-constant-condition": [
"error",
{
Expand Down Expand Up @@ -1461,6 +1464,9 @@
"allowObjectPatternsAsParameters": false
}
],
"no-empty-static-block": [
"error"
],
"no-eval": [
"error",
{
Expand Down Expand Up @@ -1505,13 +1511,6 @@
"no-import-assign": [
"off"
],
"no-inner-declarations": [
"error",
"functions",
{
"blockScopedFunctions": "allow"
}
],
"no-invalid-regexp": [
"error",
{}
Expand Down Expand Up @@ -1736,6 +1735,9 @@
"no-unused-labels": [
"error"
],
"no-unused-private-class-members": [
"error"
],
"no-unused-vars": [
"off"
],
Expand Down Expand Up @@ -1764,7 +1766,7 @@
"off"
],
"no-with": [
"error"
"off"
],
"no-wrap-func": [
"off"
Expand Down
20 changes: 11 additions & 9 deletions common/build/eslint-config-fluid/printed-configs/recommended.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"plugins": [
"@",
"@eslint-community/eslint-comments",
"@typescript-eslint:@typescript-eslint/eslint-plugin@8.18.2",
"@typescript-eslint:@typescript-eslint/eslint-plugin@8.50.0",
"import-x:[email protected]",
"unicorn:[email protected]",
"@rushstack",
Expand Down Expand Up @@ -1401,6 +1401,9 @@
"no-const-assign": [
"off"
],
"no-constant-binary-expression": [
"error"
],
"no-constant-condition": [
"error",
{
Expand Down Expand Up @@ -1459,6 +1462,9 @@
"allowObjectPatternsAsParameters": false
}
],
"no-empty-static-block": [
"error"
],
"no-eval": [
"error",
{
Expand Down Expand Up @@ -1503,13 +1509,6 @@
"no-import-assign": [
"off"
],
"no-inner-declarations": [
"error",
"functions",
{
"blockScopedFunctions": "allow"
}
],
"no-invalid-regexp": [
"error",
{}
Expand Down Expand Up @@ -1734,6 +1733,9 @@
"no-unused-labels": [
"error"
],
"no-unused-private-class-members": [
"error"
],
"no-unused-vars": [
"off"
],
Expand Down Expand Up @@ -1762,7 +1764,7 @@
"off"
],
"no-with": [
"error"
"off"
],
"no-wrap-func": [
"off"
Expand Down
20 changes: 11 additions & 9 deletions common/build/eslint-config-fluid/printed-configs/strict-biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"plugins": [
"@",
"@eslint-community/eslint-comments",
"@typescript-eslint:@typescript-eslint/eslint-plugin@8.18.2",
"@typescript-eslint:@typescript-eslint/eslint-plugin@8.50.0",
"import-x:[email protected]",
"unicorn:[email protected]",
"@rushstack",
Expand Down Expand Up @@ -1440,6 +1440,9 @@
"no-const-assign": [
"off"
],
"no-constant-binary-expression": [
"error"
],
"no-constant-condition": [
"error",
{
Expand Down Expand Up @@ -1498,6 +1501,9 @@
"allowObjectPatternsAsParameters": false
}
],
"no-empty-static-block": [
"error"
],
"no-eval": [
"error",
{
Expand Down Expand Up @@ -1542,13 +1548,6 @@
"no-import-assign": [
"off"
],
"no-inner-declarations": [
"error",
"functions",
{
"blockScopedFunctions": "allow"
}
],
"no-invalid-regexp": [
"error",
{}
Expand Down Expand Up @@ -1773,6 +1772,9 @@
"no-unused-labels": [
"error"
],
"no-unused-private-class-members": [
"error"
],
"no-unused-vars": [
"off"
],
Expand Down Expand Up @@ -1801,7 +1803,7 @@
"off"
],
"no-with": [
"error"
"off"
],
"no-wrap-func": [
"off"
Expand Down
Loading
Loading