Skip to content

Conversation

@tylerbutler
Copy link
Member

wip

Add proper CommonJS environment support for ESLint flat config:
- Import globals package and add as dependency
- Configure cjsConfig with node/commonjs globals and sourceType
- Add jsCommonjsConfig for .js files using require/exports
- Ignore .cjs files in package-level test configs to prevent overrides

Fixes 20 ESLint errors across 6 packages caused by missing CommonJS
globals (require, module, exports, __dirname, __filename) after flat
config migration.
Add a script that automatically generates a JSON file listing all deprecated
ESLint rules from core ESLint and all plugins used in the config. This enables
tooling to programmatically identify and handle deprecated rules.

The script:
- Queries rule metadata from ESLint core and 12 plugins
- Tracks which deprecated rules are configured in our ESLint configs
- Records replacement rules when available
- Supports both flat config (flat.mts) and legacy CJS configs

Output is written to printed-configs/deprecated-rules.json.
…at-config

# Conflicts:
#	common/build/eslint-config-fluid/package.json
#	common/build/eslint-config-fluid/pnpm-lock.yaml
#	common/build/eslint-config-fluid/printed-configs/deprecated-rules.json
#	common/build/eslint-config-fluid/scripts/generate-deprecated-rules.ts
@github-actions
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  248787 links
    1796 destination URLs
    2036 URLs ignored
       0 warnings
       0 errors


@tylerbutler
Copy link
Member Author

Closing in favor of #26202.

@tylerbutler tylerbutler deleted the flat-config branch January 14, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant