-
Notifications
You must be signed in to change notification settings - Fork 562
build(client): create native eslint9 flat config #26085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbutler
commented
Dec 19, 2025
Add proper CommonJS environment support for ESLint flat config: - Import globals package and add as dependency - Configure cjsConfig with node/commonjs globals and sourceType - Add jsCommonjsConfig for .js files using require/exports - Ignore .cjs files in package-level test configs to prevent overrides Fixes 20 ESLint errors across 6 packages caused by missing CommonJS globals (require, module, exports, __dirname, __filename) after flat config migration.
Add a script that automatically generates a JSON file listing all deprecated ESLint rules from core ESLint and all plugins used in the config. This enables tooling to programmatically identify and handle deprecated rules. The script: - Queries rule metadata from ESLint core and 12 plugins - Tracks which deprecated rules are configured in our ESLint configs - Records replacement rules when available - Supports both flat config (flat.mts) and legacy CJS configs Output is written to printed-configs/deprecated-rules.json.
…at-config # Conflicts: # common/build/eslint-config-fluid/package.json # common/build/eslint-config-fluid/pnpm-lock.yaml # common/build/eslint-config-fluid/printed-configs/deprecated-rules.json # common/build/eslint-config-fluid/scripts/generate-deprecated-rules.ts
Contributor
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
Member
Author
|
Closing in favor of #26202. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip