Enable snapshot refresh lifecycle tests #26116
Open
+13
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables previously skipped snapshot refresh lifecycle tests and includes several code quality improvements. The tests validate snapshot refresh behavior under various conditions including offline loading, pending operations, and timeouts.
- Enabled comprehensive lifecycle tests by removing
.skip - Fixed incorrect variable references in test setup
- Improved code maintainability with extracted constants and computed timeout values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling previously skipped snapshot refresh lifecycle tests and fix a couple of bugs in the test suite:
I ran the e2e pipeline tests 10+ times with no error repro. I'll be monitoring these tests closely and alert OCE before merging in case this tests are still flaky once PR merges.