Skip to content
Merged
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
cfded76
Add prepareDisconnectedPresence util to testUtils.ts
WillieHabi Jan 5, 2026
1e15826
Add self-attendee tests to presenceManager.spec.ts:
WillieHabi Jan 5, 2026
a11008f
emit "attendeeConnected" for self-attendee
WillieHabi Jan 5, 2026
499857c
remove duplicate code in testUtils by composing prepareConnectedPrese…
WillieHabi Jan 7, 2026
3a15cf6
fix assert to be more clear
WillieHabi Jan 7, 2026
ed55c2c
restructure attendeeConnected assert
WillieHabi Jan 7, 2026
75ab983
Add test: has status "Disconnected" when presence initializes while s…
WillieHabi Jan 8, 2026
40372df
replace usage of selfAttendeeId and selfClientConnectionId
WillieHabi Jan 8, 2026
0ef728f
requested changes
WillieHabi Jan 8, 2026
87c473e
no need to specify initial when naming attendeeId since it is stable
WillieHabi Jan 8, 2026
cce825b
attendeeDisconnected test
WillieHabi Jan 8, 2026
bab88b6
rename syncWithQuorum
WillieHabi Jan 9, 2026
3ceadd4
track quorum sequence number properly
WillieHabi Jan 9, 2026
da41270
fix buildClientDataArray comment
WillieHabi Jan 9, 2026
01bccd8
add localClient to initial audience
WillieHabi Jan 12, 2026
74e9b31
explicit naming for rejoining clients in tests
WillieHabi Jan 12, 2026
31644f8
return localAvgLatency from preparePresence
WillieHabi Jan 12, 2026
32d2945
remove duplicaiton from preparePresence functions
WillieHabi Jan 12, 2026
9ecb5e5
localClient renames
WillieHabi Jan 12, 2026
ec059e9
assert clientId not in quorum or audience in prepareDisconnectedPresence
WillieHabi Jan 12, 2026
acd0e31
reorder tests
WillieHabi Jan 12, 2026
29975b0
rename rejoin value instead of symbol
WillieHabi Jan 12, 2026
3f58402
extract prepareExpectedClientJoin into it's own function
WillieHabi Jan 14, 2026
1a00044
rename test: self attendee is announced via `attendeeConnected` while…
WillieHabi Jan 14, 2026
526a086
move rejoinedLocalClientConnectionId1 and rejoinedLocalClientConnecti…
WillieHabi Jan 14, 2026
eb84f63
rename createPresence function
WillieHabi Jan 14, 2026
c148606
move export of initialLocalClientConnectionId near other exported con…
WillieHabi Jan 14, 2026
a5f3e3a
type-import styling for mockEphemeralRuntime in testUtils.ts
WillieHabi Jan 14, 2026
079a073
move removal of client from audience to prepareDisconnectedPresence
WillieHabi Jan 14, 2026
e9d58cb
format test name
WillieHabi Jan 14, 2026
914a8a0
move localAvgLatency in beforeEach scope
WillieHabi Jan 15, 2026
8b6036f
remove `addAudienceWriteClientsToQuorum`.
WillieHabi Jan 15, 2026
4f8af2e
restore comment and rename disconnected test
WillieHabi Jan 15, 2026
264a9c9
add "has status "Disconnected" when runtime is connected but self is …
WillieHabi Jan 15, 2026
d025ef6
test: "is announced via `attendeeConnected` when added to Audience wh…
WillieHabi Jan 15, 2026
21d2ac5
Merge branch 'main' into presence-fix-self-attendee-connected
WillieHabi Jan 15, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/framework/presence/src/systemWorkspace.ts
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,7 @@ class SystemWorkspaceImpl implements PresenceStatesInternal, SystemWorkspace {
this.staleConnectionTimer.setTimeout(this.resolveStaleConnections.bind(this), 30_000);

this.selfAttendee.setConnected();
// TODO: AB#56686: self-Attendee never announced as Connected - Emit this event once there are tests in place
// this.events.emit("attendeeConnected", this.selfAttendee);
this.events.emit("attendeeConnected", this.selfAttendee);
}
}

Expand Down
Loading
Loading