refactor(build-tools): convert package from CommonJS to ESM #26130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert the @fluidframework/build-tools package from CommonJS to ES Modules, following the patterns established in build-infrastructure. Key changes: - Add "type": "module" and exports field to package.json - Convert bin scripts from require() to ESM imports (.mjs) - Replace __dirname with fileURLToPath(import.meta.url) pattern - Add createRequire for dynamic require() and require.resolve() calls - Add .js extensions to all relative imports - Update ESM-incompatible imports (fs-extra, json5, typescript) to use default import pattern - Simplify find-up imports (no longer need dynamic import workaround) - Update test tsconfig to use node16 module resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converts the
@fluidframework/build-toolspackage from CommonJS to ES Modules, following patterns frombuild-infrastructure.Changes
"type": "module"andexportsfield to package.jsonrequire()to ESM.mjsfiles with dynamic imports__dirnamereplacement: UsesfileURLToPath(import.meta.url)pattern in 3 files (utils.ts, workerPool.ts, test/init.ts)createRequirefromnode:modulefor runtime module loading (tscUtils.ts, taskUtils.ts, worker files).jsextensions to all relative imports (~50 files)node16module resolution