Skip to content

Conversation

@brrichards
Copy link
Contributor

@brrichards brrichards commented Jan 8, 2026

Remove testing infrastructure and unused dependencies from the inventory-app example to simplify the package. Further Mocha testing will be added on later.

  • Remove jest and puppeteer test configuration (jest.config.cjs, jest-puppeteer.config.cjs)
    • Delete test files
    • Remove 11 test-related devDependencies
    • Remove 3 unused production dependencies
    • Clean up tsconfig.json to remove test type references

brrichards and others added 2 commits January 7, 2026 23:05
Remove jest, puppeteer, and all test-related configuration to simplify the
example. Webpack dev server is preserved for running the example.

- Delete jest.config.cjs and jest-puppeteer.config.cjs
- Delete tests/main.test.ts
- Remove test scripts and 11 test devDependencies from package.json
- Clean up tsconfig.json to remove test type references
🤖 Generated with [Nori](https://nori.ai)

Co-Authored-By: Nori <[email protected]>
@brrichards brrichards force-pushed the trim-inventory-example branch from b33e41b to f1ee0fe Compare January 8, 2026 00:41
@brrichards brrichards force-pushed the trim-inventory-example branch from f1ee0fe to d3819c8 Compare January 8, 2026 00:42
@brrichards brrichards marked this pull request as ready for review January 8, 2026 03:56
Copilot AI review requested due to automatic review settings January 8, 2026 03:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the Jest and Puppeteer testing infrastructure from the inventory-app example to simplify the package, with plans to add Mocha testing later.

Key changes:

  • Removes Jest and Puppeteer configuration files and test files
  • Removes 11 test-related devDependencies and 3 unused production dependencies from package.json
  • Cleans up tsconfig.json by removing test-specific type references

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pnpm-lock.yaml Updates lockfile to reflect removal of test dependencies and unused production dependencies
examples/data-objects/inventory-app/tsconfig.json Removes test-specific type references (jest, puppeteer, jest-environment-puppeteer, expect-puppeteer), keeping only react types
examples/data-objects/inventory-app/tests/main.test.ts Deletes the test file containing Jest/Puppeteer integration tests
examples/data-objects/inventory-app/package.json Removes test scripts and 14 dependencies (11 test-related devDependencies and 3 unused production dependencies)
examples/data-objects/inventory-app/jest.config.cjs Deletes Jest configuration file
examples/data-objects/inventory-app/jest-puppeteer.config.cjs Deletes Puppeteer configuration file for Jest
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@brrichards brrichards merged commit f3fcbe2 into microsoft:main Jan 9, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants