fix(driver-utils): add missing return type to policies getter #26161
Conversation
|
Commenter does not have sufficient privileges for PR 26161 in repo microsoft/FluidFramework |
1 similar comment
|
Commenter does not have sufficient privileges for PR 26161 in repo microsoft/FluidFramework |
|
/azp run Build - api-markdown-documenter, Build - benchmark-tool, Build - build-common, Build - build-tools, Build - client packages, Build - common-utils, Build - eslint-config-fluid, Build - eslint-plugin-fluid, Build - protocol-definitions, Build - test-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run repo-policy-check, server-gitrest, server-gitssh, server-historian, server-routerlicious |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR adds an explicit return type annotation to the policies getter in a test mock class to satisfy the @typescript-eslint/explicit-function-return-type ESLint rule.
Key Changes
- Adds return type annotation
: undefinedto thepoliciesgetter inMockStorageServiceclass
packages/loader/driver-utils/src/test/prefetchDocumentStorageService.spec.ts
Outdated
Show resolved
Hide resolved
Add explicit return type to satisfy @typescript-eslint/explicit-function-return-type rule. Co-Authored-By: anthony-murphy <[email protected]> Co-Authored-By: Claude Opus 4.5 <[email protected]>
Head branch was pushed to by a user without write access
anthony-murphy-agent
force-pushed
the
fix/driver-utils-eslint-return-type
branch
from
8dbc64c to
bcd701f
Compare
|
Azure Pipelines commands (copy and post separately, limit of 10 at a time): |
|
/azp run Build - api-markdown-documenter, Build - benchmark-tool, Build - build-common, Build - build-tools, Build - client packages, Build - common-utils, Build - eslint-config-fluid, Build - eslint-plugin-fluid, Build - protocol-definitions, Build - test-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run repo-policy-check, server-gitrest, server-gitssh, server-historian, server-routerlicious |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…oft#26161) ## Summary - Adds explicit return type to `policies` getter in test mock to satisfy `@typescript-eslint/explicit-function-return-type` rule ## Root cause Race condition between two PRs: | Event | Time (UTC) | |-------|------------| | PR microsoft#26151 created (prefetch fix) | Jan 7, 23:12 | | PR microsoft#26149 merged (ESLint rule promotion) | Jan 8, 01:45 | | PR microsoft#26151 merged | Jan 8, 18:38 | PR microsoft#26151's CI ran before the ESLint rule was promoted in microsoft#26149. By the time microsoft#26151 was merged, the stricter linting rule was already in place, but CI wasn't re-run against the updated main branch. ## Test plan - [x] ESLint passes locally 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: anthony-murphy-agent <[email protected]> Co-authored-by: anthony-murphy <[email protected]> Co-authored-by: Claude Opus 4.5 <[email protected]>
3 participants
Summary
policiesgetter in test mock to satisfy@typescript-eslint/explicit-function-return-typeruleRoot cause
Race condition between two PRs:
PR #26151's CI ran before the ESLint rule was promoted in #26149. By the time #26151 was merged, the stricter linting rule was already in place, but CI wasn't re-run against the updated main branch.
Test plan
🤖 Generated with Claude Code