build(client-presence): fix gen-version build order dependency #26170
Conversation
Since packageVersion.ts is used it should be updated before compiling main code.
There was a problem hiding this comment.
Pull request overview
This PR fixes a build order dependency issue in the @fluidframework/presence package by ensuring that packageVersion.ts is generated before the main TypeScript compilation runs.
Key changes:
- Added
build:genveras a dependency to thebuild:esnext:maintask - Added
build:genveras a dependency to thetsc:maintask
tylerbutler
left a comment
tylerbutler
left a comment
There was a problem hiding this comment.
Change looks great. Is this problem limited to presence because of its specific build, or are other packages hiding this problem somehow?
Limited to presence as far as I know. Presence wasn't using gen-versions for a long time but did get custom tasks along the way. I only noticed because I am investigating if breaking presence up is the right thing to enforce certain boundaries between presence elements. |
…soft#26170) Since packageVersion.ts is used it should be updated before compiling main code.
2 participants
Since packageVersion.ts is used it should be updated before compiling main code.