Remove ID Allocation Batch, instead JIT generating ID Allocations right before submitting other batch types#26779
Closed
markfields wants to merge 4 commits intomicrosoft:mainfrom
Closed
Remove ID Allocation Batch, instead JIT generating ID Allocations right before submitting other batch types#26779markfields wants to merge 4 commits intomicrosoft:mainfrom
markfields wants to merge 4 commits intomicrosoft:mainfrom
Conversation
…tions right before submitting other batch types. This gets rid of ID Allocation Batches in the batch stream which makes detecting forked containers more robust and simple.
Per Claude: The key insight from the e2e test failure: creating a standalone ID alloc batch during reconnect adds an unexpected entry to the pending queue, causing BatchInfoMismatch when the original (or forked) batches arrive. The flag approach avoids this by prepending the comprehensive range INTO the first replayed batch, preserving batch structure and CSN alignment for fork detection.
markfields
commented
Mar 19, 2026
| // Signal to the outbox that the next JIT ID allocation should use the comprehensive | ||
| // unfinalized range (instead of incremental). The range will be prepended to the | ||
| // first replayed batch, preserving batch structure for fork detection. | ||
| this.outbox.requestUnfinalizedIdRanges(); |
Member
Author
There was a problem hiding this comment.
This mechanism can go away if we merge #26784 first
Member
Author
|
Replaced by #26898 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PROTOTYPE / PROOF OF CONCEPT
This gets rid of ID Allocation Batches in the batch stream which makes detecting forked containers more robust and simple.
(Incidental rebirth of #24510 a year later)